fixed issue: processing/p5.js-sound#297

yunussaha · yunussaha · commit 650c9cedf504 · 2018-06-20T12:07:33.000+05:30
diff --git a/examples/soundfile_remove_cue/index.html b/examples/soundfile_remove_cue/index.html
@@ -0,0 +1,10 @@
+<head>
+  <script language="javascript" type="text/javascript" src="../../lib/p5.js"></script>
+
+  <script language="javascript" type="text/javascript" src="../../lib/addons/p5.dom.js"></script> 
+
+  <script language="javascript" type="text/javascript" src="../../lib/p5.sound.js"></script> 
+
+  <script language="javascript" type="text/javascript" src="sketch.js"></script> 
+
+</head>
diff --git a/examples/soundfile_remove_cue/sketch.js b/examples/soundfile_remove_cue/sketch.js
@@ -0,0 +1,41 @@
+function setup() {
+  background(0);
+  noStroke();
+  fill(255);
+  textAlign(CENTER);
+  text('click to play', width/2, height/2);
+
+  mySound = loadSound('../files/beat.mp3');
+  
+  // schedule calls to changeText
+  var firstCueId = mySound.addCue(0.50, changeText, "hello" );
+  mySound.addCue(1.00, changeText, "p5" );
+  var thirdCueId = mySound.addCue(1.50, changeText, "what" );
+  mySound.addCue(2.00, changeText, "do" );
+  mySound.addCue(2.50, changeText, "you" );
+  mySound.addCue(3.00, changeText, "want" );
+  mySound.addCue(4.00, changeText, "to" );
+  mySound.addCue(5.00, changeText, "make" );
+  mySound.addCue(6.00, changeText, "?" );
+  
+  //remove the first cue
+  mySound.removeCue(firstCueId);
+  
+  //remove the third cue
+  mySound.removeCue(thirdCueId);
+}
+
+function changeText(val) {
+  background(0);
+  text(val, width/2, height/2);
+}
+
+function mouseClicked() {
+  if (mouseX > 0 && mouseX < width && mouseY > 0 && mouseY < height) {
+    if (mySound.isPlaying() ) {
+      mySound.stop();
+    } else {
+      mySound.play();
+    }
+  }
+}
diff --git a/lib/p5.sound.js b/lib/p5.sound.js
@@ -1,4 +1,4 @@
-/*! p5.sound.js v0.3.8 2018-06-15 */
+/*! p5.sound.js v0.3.8 2018-06-20 */
 /**
  *  p5.sound extends p5 with <a href="http://caniuse.com/audio-api"
  *  target="_blank">Web Audio</a> functionality including audio input,
@@ -881,6 +881,7 @@ soundfile = function () {
     this._pauseTime = 0;
     // cues for scheduling events with addCue() removeCue()
     this._cues = [];
+    this._cueIDCounter = 0;
     //  position of the most recently played sample
     this._lastPos = 0;
     this._counterNode = null;
@@ -2195,7 +2196,8 @@ soundfile = function () {
     for (var i = 0; i < cueLength; i++) {
       var cue = this._cues[i];
       if (cue.id === id) {
-        this.cues.splice(i, 1);
+        this._cues.splice(i, 1);
+        break;
       }
     }
     if (this._cues.length === 0) {
diff --git a/lib/p5.sound.min.js b/lib/p5.sound.min.js
diff --git a/src/soundfile.js b/src/soundfile.js
@@ -88,6 +88,7 @@ define(function (require) {
 
     // cues for scheduling events with addCue() removeCue()
     this._cues = [];
+	this._cueIDCounter = 0;
 
     //  position of the most recently played sample
     this._lastPos = 0;
@@ -1595,7 +1596,8 @@ define(function (require) {
     for (var i = 0; i < cueLength; i++) {
       var cue = this._cues[i];
       if (cue.id === id) {
-        this.cues.splice(i, 1);
+        this._cues.splice(i, 1);
+		break;
       }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,7 @@ define(function (require) {`
`88`	`88`
`89`	`89`	`// cues for scheduling events with addCue() removeCue()`
`90`	`90`	`this._cues = [];`
	`91`	`+ this._cueIDCounter = 0;`
`91`	`92`
`92`	`93`	`// position of the most recently played sample`
`93`	`94`	`this._lastPos = 0;`
`@@ -1595,7 +1596,8 @@ define(function (require) {`
`1595`	`1596`	`for (var i = 0; i < cueLength; i++) {`
`1596`	`1597`	`var cue = this._cues[i];`
`1597`	`1598`	`if (cue.id === id) {`
`1598`		`- this.cues.splice(i, 1);`
	`1599`	`+ this._cues.splice(i, 1);`
	`1600`	`+ break;`
`1599`	`1601`	`}`
`1600`	`1602`	`}`
`1601`	`1603`