Skip to content

Possible issue with offline event trigger #270

@W1nstar

Description

@W1nstar

Hello,

I am trying to use the offline event to do some logic on my app. Turns out, it is never called.

In the processPingResult, there's this line:

        if (args.fireEventIfOfflineChange) {
            if (wasOnline && !connectedBeforeCallback) {
                that.trigger("offline", that, args.offlineReason, null);
            } else if (!wasOnline && connectedBeforeCallback) {
                that.trigger("online", that, null);
            }
        }

On my tests, wasOnline and connectedBeforeCallback are both true, therefore it always try to trigger the online event.
My tests are very simple, I just stop OEPAS and hope for the event to trigger, but it does not.
By debugging this _processPingResult function I can see that the function correctly identifies the reason of the ping failur (server offline), but when it evaluates the triggers, it always resorts to trigger online instead of online.

Can you guys confirm it's an error?

Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions