Merge pull request #42 from progrium/quiet-exit-status-logs

josegonzalez · web-flow · commit e40ee14bd475 · 2022-05-15T23:39:28.000-04:00
Do not log exit status messages
diff --git a/basher.go b/basher.go
@@ -94,7 +94,14 @@ func ApplicationWithPath(
 	}
 	status, err := bash.Run("main", os.Args[1:])
 	if err != nil {
-		log.Fatal(err)
+		// the string message for ExitError shouldn't be logged
+		// as it is just `exit status $CODE`, which is redundant
+		// when that code can just be used to exit the program
+		if _, ok := err.(*exec.ExitError); ok && strings.HasPrefix(err.Error(), "exit status ") {
+			os.Exit(status)
+		} else {
+			log.Fatal(err)
+		}
 	}
 	os.Exit(status)
 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,14 @@ func ApplicationWithPath(`
`94`	`94`	`}`
`95`	`95`	`status, err := bash.Run("main", os.Args[1:])`
`96`	`96`	`if err != nil {`
`97`		`- log.Fatal(err)`
	`97`	`+ // the string message for ExitError shouldn't be logged`
	`98`	+ // as it is just `exit status $CODE`, which is redundant
	`99`	`+ // when that code can just be used to exit the program`
	`100`	`+ if _, ok := err.(*exec.ExitError); ok && strings.HasPrefix(err.Error(), "exit status ") {`
	`101`	`+ os.Exit(status)`
	`102`	`+ } else {`
	`103`	`+ log.Fatal(err)`
	`104`	`+ }`
`98`	`105`	`}`
`99`	`106`	`os.Exit(status)`
`100`	`107`	`}`