Skip to content

NO-JIRA: Update Ray to 2.52.1 #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v0.31
Choose a base branch
from
Open

NO-JIRA: Update Ray to 2.52.1 #954

wants to merge 1 commit into from

Conversation

@kryanbeane
Copy link
Contributor

@kryanbeane kryanbeane commented Dec 2, 2025

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Dec 2, 2025

@kryanbeane: This pull request explicitly references no jira issue.

In response to this:

Issue link

What changes have been made

Verification steps

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kryanbeane for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kryanbeane
Copy link
Contributor Author

kryanbeane commented Dec 2, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2025
kryanbeane
kryanbeane commented Dec 2, 2025
View reviewed changes
src/codeflare_sdk/common/utils/constants.py
"""
CUDA_PY311_RUNTIME_IMAGE = "quay.io/modh/ray@sha256:6d076aeb38ab3c34a6a2ef0f58dc667089aa15826fa08a73273c629333e12f1e"
CUDA_PY312_RUNTIME_IMAGE = "quay.io/modh/ray@sha256:fb6f207de63e442c67bb48955cf0584f3704281faf17b90419cfa274fdec63c5"
CUDA_PY311_RUNTIME_IMAGE = "quay.io/modh/ray@sha256:TODO"
Copy link
Contributor Author

@kryanbeane kryanbeane Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the image SHAs we can update this

Copy link
Contributor Author

@kryanbeane kryanbeane Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to decide if we need to build 3.11 image

@pawelpaszki
Copy link
Contributor

pawelpaszki commented Dec 2, 2025

for 2.52.1 these lines need to be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

@pawelpaszki pawelpaszki Awaiting requested review from pawelpaszki

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kryanbeane @openshift-ci-robot @pawelpaszki