create_prompt_application missing from 2.x

[ibeex]

>>> prompt_toolkit.__version__
'2.0.3'
>>> from prompt_toolkit.shortcuts import create_prompt_application
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'create_prompt_application'

ipython and lots off other apps don't work any more.

[jonathanslenders]

Hi @ibeex,

IPython does indeed not yet run on prompt_toolkit 2.0. They're working hard on that.
See this issue: ipython/ipython#11177

If you have some time available, it would be great if you could help them testing the latest IPython version from GitHub.

[jonathanslenders]

Actually, many of these applications have pull requests to upgrade to prompt_toolkit 2.0, but they need a little more (help with) testing before getting merged. For now, in any case, they have specified 1.0 in their setup.py.

See:

• Added prompt_toolkit 2.0 support. dbcli/pgcli#826
• Ptk 2.0! xonsh/xonsh#2570
• [WIP] Upgrade to prompt_toolkit 2.0 nicolewhite/cycli#61
• [WIP] Upgrade to prompt_toolkit 2.0. donnemartin/gitsome#143
• Compatibility with prompt_toolkit 2.0 ergonomica/ergonomica#106
• [WIP] Upgrade to prompt_toolkit 2.0 donnemartin/haxor-news#118
• [WIP] Upgrade to prompt_toolkit 2.0 j-bennet/wharfee#158
• [WIP] Upgrade to prompt_toolkit 2.0 httpie/http-prompt#137
• Upgrade to prompt_toolkit 2.0 ipython/ipython#11177

[techtonik]

IPython merged, but is there a porting guide for all other apps?

[jonathanslenders]

There is: https://python-prompt-toolkit.readthedocs.io/en/2.0/pages/upgrading.html
It's probably not complete, but let me know if you think something important is missing.

[ProbonoBonobo]

For anyone needing a temporary workaround, I can confirm that reverting to v.1.x mostly resolves the errors that prevent ipython, ptpython, etc. from initializing:

$ git clone -b 1.0  --single-branch https://github.com/jonathanslenders/python-prompt-toolkit.git
$ cd python-prompt-toolkit 
$ python3 setup.py install 
$ cd ..
$ export python_prompt_toolkit_install_dir=$(pip3 show prompt_toolkit | echo $(grep -w "Location:")  | awk '{ print substr( $0, 11 ) }')/prompt-toolkit
$ pip3 uninstall prompt_toolkit
$ cp -Rf python-prompt-toolkit $python_prompt_toolkit_install_dir

You might get the following error when launching ptpython if you're using the default config.py template...

~/dev/git/clones/python-prompt-toolkit$ ptpython
Traceback (most recent call last):
  File "/home/kevin/.local/lib/python3.6/site-packages/ptpython/repl.py", line 244, in run_config
    six.exec_(code, namespace, namespace)
  File "/home/kevin/.ptpython/config.py", line 8, in <module>
    from prompt_toolkit.key_binding.key_processor import KeyPress
ModuleNotFoundError: No module named 'prompt_toolkit.key_binding.key_processor'

...but it's not fatal, and can be safely ignored, or you could delete the offending lines. A quick glance at the code suggests KeyPress is only used to map the 'jj' key sequence to 'Esc' in vim mode.

[ProbonoBonobo]

@jonathanslenders Weird... the kludge above worked for me yesterday, but it's throwing the following stacktrace today:

$ ptpython
Traceback (most recent call last):
  File "/home/kevin/.local/bin/ptpython", line 7, in <module>
    from ptpython.entry_points.run_ptpython import run
  File "/home/kevin/.local/lib/python3.6/site-packages/ptpython/entry_points/run_ptpython.py", line 25, in <module>
    from ptpython.repl import embed, enable_deprecation_warnings, run_config
  File "/home/kevin/.local/lib/python3.6/site-packages/ptpython/repl.py", line 15, in <module>
    from prompt_toolkit.application import AbortAction
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/__init__.py", line 16, in <module>
    from .interface import CommandLineInterface
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/interface.py", line 19, in <module>
    from .application import Application, AbortAction
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/application/__init__.py", line 2, in <module>
    from .application import Application
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/application/application.py", line 3, in <module>
    from prompt_toolkit.buffer import Buffer
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/buffer.py", line 9, in <module>
    from .completion import Completer, Completion, CompleteEvent
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/completion/__init__.py", line 2, in <module>
    from .base import Completion, Completer, ThreadedCompleter, DummyCompleter, DynamicCompleter, CompleteEvent, merge_completers, get_common_complete_suffix
  File "/home/kevin/.local/lib/python3.6/site-packages/prompt_toolkit/completion/base.py", line 4, in <module>
    from prompt_toolkit.eventloop import generator_to_async_generator, AsyncGeneratorItem
ImportError: cannot import name 'generator_to_async_generator'

Can you suggest a better workaround? I'm utterly hooked on your excellent ptpython REPL and I'm afraid I don't understand the nature of these breaking changes well enough to patch them.

Edit: my bad, I assumed incorrectly that running "python3 setup.py install" would replace the existing prompt-toolkit installation -- it doesn't. I'm guessing this worked yesterday only because I was already in the cloned downstream branch. I'll edit the instructions.

[gpotter2]

I think this issue could be closed :)

[jonathanslenders]

Ok, closing it. Feel free to open again if needed.