Remove misleading error logs

jakub-grzesiowski · jakub-grzesiowski · commit 40109978ab77 · 2025-09-15T15:24:16.000+02:00
diff --git a/c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/Chat.cs b/c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/Chat.cs
@@ -191,7 +191,7 @@ public async Task<ChatOperationResult<Channel>> CreatePublicConversation(string
         {
             var result = new ChatOperationResult<Channel>("Chat.CreatePublicConversation()", this);
             var existingChannel = await GetChannel(channelId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingChannel, false))
+            if (!result.RegisterOperation(existingChannel))
             {
                 Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");
                 result.Result = existingChannel.Result;
@@ -224,7 +224,7 @@ private async Task<ChatOperationResult<CreatedChannelWrapper>> CreateConversatio
             }
             
             var existingChannel = await GetChannel(channelId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingChannel, false))
+            if (!result.RegisterOperation(existingChannel))
             {
                 Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");
                 result.Result.CreatedChannel = existingChannel.Result;
@@ -333,7 +333,7 @@ public async Task<ChatOperationResult<Membership>> InviteToChannel(string channe
             var result = new ChatOperationResult<Membership>("Chat.InviteToChannel()", this);
             //Check if already a member first
             var members = await GetChannelMemberships(channelId, filter:$"uuid.id == \"{userId}\"").ConfigureAwait(false);
-            if (!result.RegisterOperation(members, false) && members.Result.Memberships.Any())
+            if (!result.RegisterOperation(members) && members.Result.Memberships.Any())
             {
                 //Already a member, just return current membership
                 result.Result = members.Result.Memberships[0];
@@ -817,7 +817,7 @@ public async Task<ChatOperationResult<User>> CreateUser(string userId, ChatUserD
         {
             var result = new ChatOperationResult<User>("Chat.CreateUser()", this);
             var existingUser = await GetUser(userId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingUser, false))
+            if (!result.RegisterOperation(existingUser))
             {
                 result.Result = existingUser.Result;
                 return result;
diff --git a/c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/Data/ChatOperationResult.cs b/c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/Data/ChatOperationResult.cs
@@ -24,17 +24,14 @@ internal ChatOperationResult(string operationName, Chat chat)
         /// Registers a single PNResult to this overall Chat Operation Result.
         /// Returns pubnubResult.Status.Error
         /// </summary>
-        internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = true)
+        internal bool RegisterOperation<T>(PNResult<T> pubnubResult)
         {
             InternalStatuses.Add(pubnubResult.Status);
             chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status: {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(pubnubResult.Status)}");
             Error = pubnubResult.Status.Error;
             if (Error)
             {
-                if (logIfError)
-                {
-                    chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");
-                }
+                chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");
                 Exception = pubnubResult.Status.ErrorData.Throwable;
             }
             return Error;
@@ -44,17 +41,17 @@ internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = t
         /// Registers another ChatOperationResult to this ChatOperationResult.
         /// Returns otherChatResult.Error
         /// </summary>
-        internal bool RegisterOperation(ChatOperationResult otherChatResult, bool logIfError = true)
+        internal bool RegisterOperation(ChatOperationResult otherChatResult)
         {
             foreach (var status in otherChatResult.InternalStatuses)
             {
                 chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\": {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(status)}");
                 InternalStatuses.Add(status);
 
             }
-            if (otherChatResult.Error && logIfError)
+            if (otherChatResult.Error)
             {
-                chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");
+                chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");
             }
             Exception = otherChatResult.Exception;
             Error = otherChatResult.Error;
diff --git a/unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/Chat.cs b/unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/Chat.cs
@@ -191,7 +191,7 @@ public async Task<ChatOperationResult<Channel>> CreatePublicConversation(string
         {
             var result = new ChatOperationResult<Channel>("Chat.CreatePublicConversation()", this);
             var existingChannel = await GetChannel(channelId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingChannel, false))
+            if (!result.RegisterOperation(existingChannel))
             {
                 Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");
                 result.Result = existingChannel.Result;
@@ -224,7 +224,7 @@ private async Task<ChatOperationResult<CreatedChannelWrapper>> CreateConversatio
             }
             
             var existingChannel = await GetChannel(channelId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingChannel, false))
+            if (!result.RegisterOperation(existingChannel))
             {
                 Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");
                 result.Result.CreatedChannel = existingChannel.Result;
@@ -333,7 +333,7 @@ public async Task<ChatOperationResult<Membership>> InviteToChannel(string channe
             var result = new ChatOperationResult<Membership>("Chat.InviteToChannel()", this);
             //Check if already a member first
             var members = await GetChannelMemberships(channelId, filter:$"uuid.id == \"{userId}\"").ConfigureAwait(false);
-            if (!result.RegisterOperation(members, false) && members.Result.Memberships.Any())
+            if (!result.RegisterOperation(members) && members.Result.Memberships.Any())
             {
                 //Already a member, just return current membership
                 result.Result = members.Result.Memberships[0];
@@ -817,7 +817,7 @@ public async Task<ChatOperationResult<User>> CreateUser(string userId, ChatUserD
         {
             var result = new ChatOperationResult<User>("Chat.CreateUser()", this);
             var existingUser = await GetUser(userId).ConfigureAwait(false);
-            if (!result.RegisterOperation(existingUser, false))
+            if (!result.RegisterOperation(existingUser))
             {
                 result.Result = existingUser.Result;
                 return result;
diff --git a/unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/Data/ChatOperationResult.cs b/unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/Data/ChatOperationResult.cs
@@ -24,17 +24,14 @@ internal ChatOperationResult(string operationName, Chat chat)
         /// Registers a single PNResult to this overall Chat Operation Result.
         /// Returns pubnubResult.Status.Error
         /// </summary>
-        internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = true)
+        internal bool RegisterOperation<T>(PNResult<T> pubnubResult)
         {
             InternalStatuses.Add(pubnubResult.Status);
             chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status: {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(pubnubResult.Status)}");
             Error = pubnubResult.Status.Error;
             if (Error)
             {
-                if (logIfError)
-                {
-                    chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");
-                }
+                chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");
                 Exception = pubnubResult.Status.ErrorData.Throwable;
             }
             return Error;
@@ -44,17 +41,17 @@ internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = t
         /// Registers another ChatOperationResult to this ChatOperationResult.
         /// Returns otherChatResult.Error
         /// </summary>
-        internal bool RegisterOperation(ChatOperationResult otherChatResult, bool logIfError = true)
+        internal bool RegisterOperation(ChatOperationResult otherChatResult)
         {
             foreach (var status in otherChatResult.InternalStatuses)
             {
                 chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\": {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(status)}");
                 InternalStatuses.Add(status);
 
             }
-            if (otherChatResult.Error && logIfError)
+            if (otherChatResult.Error)
             {
-                chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");
+                chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");
             }
             Exception = otherChatResult.Exception;
             Error = otherChatResult.Error;

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ public async Task<ChatOperationResult<Channel>> CreatePublicConversation(string`
`191`	`191`	`{`
`192`	`192`	`var result = new ChatOperationResult<Channel>("Chat.CreatePublicConversation()", this);`
`193`	`193`	`var existingChannel = await GetChannel(channelId).ConfigureAwait(false);`
`194`		`- if (!result.RegisterOperation(existingChannel, false))`
	`194`	`+ if (!result.RegisterOperation(existingChannel))`
`195`	`195`	`{`
`196`	`196`	`Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");`
`197`	`197`	`result.Result = existingChannel.Result;`
`@@ -224,7 +224,7 @@ private async Task<ChatOperationResult<CreatedChannelWrapper>> CreateConversatio`
`224`	`224`	`}`
`225`	`225`
`226`	`226`	`var existingChannel = await GetChannel(channelId).ConfigureAwait(false);`
`227`		`- if (!result.RegisterOperation(existingChannel, false))`
	`227`	`+ if (!result.RegisterOperation(existingChannel))`
`228`	`228`	`{`
`229`	`229`	`Logger.Debug("Trying to create a channel with ID that already exists! Returning existing one.");`
`230`	`230`	`result.Result.CreatedChannel = existingChannel.Result;`
`@@ -333,7 +333,7 @@ public async Task<ChatOperationResult<Membership>> InviteToChannel(string channe`
`333`	`333`	`var result = new ChatOperationResult<Membership>("Chat.InviteToChannel()", this);`
`334`	`334`	`//Check if already a member first`
`335`	`335`	`var members = await GetChannelMemberships(channelId, filter:$"uuid.id == \"{userId}\"").ConfigureAwait(false);`
`336`		`- if (!result.RegisterOperation(members, false) && members.Result.Memberships.Any())`
	`336`	`+ if (!result.RegisterOperation(members) && members.Result.Memberships.Any())`
`337`	`337`	`{`
`338`	`338`	`//Already a member, just return current membership`
`339`	`339`	`result.Result = members.Result.Memberships[0];`
`@@ -817,7 +817,7 @@ public async Task<ChatOperationResult<User>> CreateUser(string userId, ChatUserD`
`817`	`817`	`{`
`818`	`818`	`var result = new ChatOperationResult<User>("Chat.CreateUser()", this);`
`819`	`819`	`var existingUser = await GetUser(userId).ConfigureAwait(false);`
`820`		`- if (!result.RegisterOperation(existingUser, false))`
	`820`	`+ if (!result.RegisterOperation(existingUser))`
`821`	`821`	`{`
`822`	`822`	`result.Result = existingUser.Result;`
`823`	`823`	`return result;`
Original file line number	Diff line number	Diff line change
`@@ -24,17 +24,14 @@ internal ChatOperationResult(string operationName, Chat chat)`
`24`	`24`	`/// Registers a single PNResult to this overall Chat Operation Result.`
`25`	`25`	`/// Returns pubnubResult.Status.Error`
`26`	`26`	`/// </summary>`
`27`		`- internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = true)`
	`27`	`+ internal bool RegisterOperation<T>(PNResult<T> pubnubResult)`
`28`	`28`	`{`
`29`	`29`	`InternalStatuses.Add(pubnubResult.Status);`
`30`	`30`	`chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status: {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(pubnubResult.Status)}");`
`31`	`31`	`Error = pubnubResult.Status.Error;`
`32`	`32`	`if (Error)`
`33`	`33`	`{`
`34`		`- if (logIfError)`
`35`		`- {`
`36`		`- chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");`
`37`		`- }`
	`34`	`+ chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status with error: {pubnubResult.Status.ErrorData.Information}");`
`38`	`35`	`Exception = pubnubResult.Status.ErrorData.Throwable;`
`39`	`36`	`}`
`40`	`37`	`return Error;`
`@@ -44,17 +41,17 @@ internal bool RegisterOperation<T>(PNResult<T> pubnubResult, bool logIfError = t`
`44`	`41`	`/// Registers another ChatOperationResult to this ChatOperationResult.`
`45`	`42`	`/// Returns otherChatResult.Error`
`46`	`43`	`/// </summary>`
`47`		`- internal bool RegisterOperation(ChatOperationResult otherChatResult, bool logIfError = true)`
	`44`	`+ internal bool RegisterOperation(ChatOperationResult otherChatResult)`
`48`	`45`	`{`
`49`	`46`	`foreach (var status in otherChatResult.InternalStatuses)`
`50`	`47`	`{`
`51`	`48`	`chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\": {chat.PubnubInstance.JsonPluggableLibrary.SerializeToJsonString(status)}");`
`52`	`49`	`InternalStatuses.Add(status);`
`53`	`50`
`54`	`51`	`}`
`55`		`- if (otherChatResult.Error && logIfError)`
	`52`	`+ if (otherChatResult.Error)`
`56`	`53`	`{`
`57`		`- chat.Logger.Error($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");`
	`54`	`+ chat.Logger.Debug($"Chat operation \"{OperationName}\" registered PN Status from operation \"{otherChatResult.OperationName}\" with error: {otherChatResult.Exception.Message}");`
`58`	`55`	`}`
`59`	`56`	`Exception = otherChatResult.Exception;`
`60`	`57`	`Error = otherChatResult.Error;`