Update PNSDK generation, some codacy fixes

Author: jakub-grzesiowski

c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/Chat.cs

@@ -24,7 +24,6 @@ namespace PubNubChatAPI.Entities
     public class Chat
     {
         internal const string INTERNAL_MODERATION_PREFIX = "PUBNUB_INTERNAL_MODERATION";
-        internal const string INTERNAL_ADMIN_CHANNEL = "PUBNUB_INTERNAL_ADMIN_CHANNEL";
         internal const string MESSAGE_THREAD_ID_PREFIX = "PUBNUB_INTERNAL_THREAD";
 
         public Pubnub PubnubInstance { get; }

c-sharp-chat/PubnubChatApi/PubnubChatApi/Entities/MessageDraft.cs

@@ -191,6 +191,10 @@ private async Task<List<SuggestedMention>> GenerateSuggestedMentions()
                             continue;
                         }
                         break;
+                    case MentionType.Url:
+                        break;
+                    default:
+                        throw new ArgumentOutOfRangeException();
                 }
                 suggestions.Add(suggestion);
             }

c-sharp-chat/PubnubChatApi/PubnubChatApi/Utilities/DiffMatchPatch.cs

@@ -428,6 +428,8 @@ private List<Diff> diff_lineMode(string text1, string text2,
             text_delete = string.Empty;
             text_insert = string.Empty;
             break;
+          default:
+            throw new ArgumentOutOfRangeException();
         }
         pointer++;
       }

unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/Chat.cs

@@ -24,7 +24,6 @@ namespace PubNubChatAPI.Entities
     public class Chat
     {
         internal const string INTERNAL_MODERATION_PREFIX = "PUBNUB_INTERNAL_MODERATION";
-        internal const string INTERNAL_ADMIN_CHANNEL = "PUBNUB_INTERNAL_ADMIN_CHANNEL";
         internal const string MESSAGE_THREAD_ID_PREFIX = "PUBNUB_INTERNAL_THREAD";
 
         public Pubnub PubnubInstance { get; }

unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Entities/MessageDraft.cs

@@ -191,6 +191,10 @@ private async Task<List<SuggestedMention>> GenerateSuggestedMentions()
                             continue;
                         }
                         break;
+                    case MentionType.Url:
+                        break;
+                    default:
+                        throw new ArgumentOutOfRangeException();
                 }
                 suggestions.Add(suggestion);
             }

unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/PubnubChatApi/Utilities/DiffMatchPatch.cs

@@ -428,6 +428,8 @@ private List<Diff> diff_lineMode(string text1, string text2,
             text_delete = string.Empty;
             text_insert = string.Empty;
             break;
+          default:
+            throw new ArgumentOutOfRangeException();
         }
         pointer++;
       }

unity-chat/PubnubChatUnity/Assets/PubnubChat/Runtime/UnityChatPNSDKSource.cs

@@ -6,24 +6,31 @@ public class UnityChatPNSDKSource : IPNSDKSource
     {
         private const string build = "0.4.5";
 
-        public string GetPNSDK() {
+        private string GetPlatformString()
+        {
 #if(UNITY_IOS)
-			        return string.Format("PubNub-CSharp-Chat-UnityIOS/{0}", build);
+			return "IOS";
 #elif(UNITY_STANDALONE_WIN)
-            return string.Format("PubNub-CSharp-Chat-UnityWin/{0}", build);
+	        return "Win";
 #elif(UNITY_STANDALONE_OSX)
-			        return string.Format("PubNub-CSharp-Chat-UnityOSX/{0}", build);
+			return "OSX";
 #elif(UNITY_ANDROID)
-			        return string.Format("PubNub-CSharp-Chat-UnityAndroid/{0}", build);
+			return "Android";
 #elif(UNITY_STANDALONE_LINUX)
-			        return string.Format("PubNub-CSharp-Chat-UnityLinux/{0}", build);
+			return "Linux";
 #elif(UNITY_WEBPLAYER)
-			        return string.Format("PubNub-CSharp-Chat-UnityWeb/{0}", build);
+			return "Web";
 #elif(UNITY_WEBGL)
-					return string.Format("PubNub-CSharp-Chat-UnityWebGL/{0}", build);
+			return "WebGL";
 #else
-			        return string.Format("PubNub-CSharp-Chat-Unity/{0}", build);
+			return "";
 #endif
         }
+        
+        public string GetPNSDK()
+        {
+	        var unitySdkVersion = new UnityPNSDKSource().Build;
+	        return $"PubNub-CSharp-Unity{GetPlatformString()}/{unitySdkVersion}/CA-Unity/{build}";
+        }
     }
 }

unity-chat/PubnubChatUnity/Packages/manifest.json

@@ -3,6 +3,7 @@
     "com.pubnub.sdk": "https://github.com/pubnub/unity.git?path=/PubNubUnity/Assets/PubNub#c-sharp-7-5-0",
     "com.unity.collab-proxy": "2.6.0",
     "com.unity.feature.development": "1.0.1",
+    "com.unity.ide.rider": "3.0.37",
     "com.unity.textmeshpro": "3.0.7",
     "com.unity.timeline": "1.7.6",
     "com.unity.ugui": "1.0.0",

unity-chat/PubnubChatUnity/Packages/packages-lock.json

@@ -7,7 +7,7 @@
       "dependencies": {
         "com.unity.nuget.newtonsoft-json": "3.0.2"
       },
-      "hash": "c7e3f452dc9feee8c3396011e157605119186058"
+      "hash": "4abedb90b80e8c615425ec4aaa397f4a62b16a98"
     },
     "com.unity.collab-proxy": {
       "version": "2.6.0",
@@ -25,7 +25,7 @@
     },
     "com.unity.ext.nunit": {
       "version": "1.0.6",
-      "depth": 2,
+      "depth": 1,
       "source": "registry",
       "dependencies": {},
       "url": "https://packages.unity.com"
@@ -45,8 +45,8 @@
       }
     },
     "com.unity.ide.rider": {
-      "version": "3.0.34",
-      "depth": 1,
+      "version": "3.0.37",
+      "depth": 0,
       "source": "registry",
       "dependencies": {
         "com.unity.ext.nunit": "1.0.6"