improve agent beaker tests

Author: Daniel Dreier

spec/acceptance/agent_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper_acceptance'
 
 describe 'agent', :unless => UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do
-  context 'with default parameters' do
+  context 'with default parameters', :agent_method => 'default' do
     it 'should run with no errors', :agent do
       pp = <<-EOS
       class { 'puppet::agent': }
@@ -13,26 +13,49 @@ class { 'puppet::agent': }
     end
   end
 
-#  context 'running as service' do
-#    it 'should run with no errors' do
-#      pp = <<-EOS
-#      class { 'puppet::agent':
-#       method        => 'service',
-#      }
-#      EOS
-
-#      # Run it twice and test for idempotency
-#      apply_manifest(pp, :catch_failures => true)
-#      expect(apply_manifest(pp, :catch_failures => true).exit_code).to be_zero
-#    end
-#
-#    describe service('puppet') do
-#      it {
-#        should be_enabled
-#      }
-#      it {
-#        should be_running
-#      }
-#    end
-#  end
+  context 'running as cron', :agent_method => 'cron'  do
+    it 'should run with no errors' do
+      pp = <<-EOS
+      class { 'puppet::agent':
+        method => 'cron',
+      }
+      EOS
+
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      expect(apply_manifest(pp, :catch_failures => true).exit_code).to be_zero
+    end
+
+    describe service('puppet') do
+      it {
+        should be_disabled
+      }
+      it {
+        should_not be_running
+      }
+    end
+  end
+  context 'running as service', :agenttype => 'service'  do
+    it 'should run with no errors' do
+      pp = <<-EOS
+      class { 'puppet::agent':
+        method => 'service',
+      }
+      EOS
+
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      expect(apply_manifest(pp, :catch_failures => true).exit_code).to be_zero
+    end
+
+    describe service('puppet') do
+      it {
+        should be_enabled
+      }
+      it {
+        should be_running
+      }
+    end
+  end
+
 end