proper removal of the arrays in server config

Author: tampakrap

manifests/server.pp

@@ -135,7 +135,7 @@
   $bindaddress       = '0.0.0.0',
   $ca                = false,
   $config_version    = '/usr/bin/git --git-dir $confdir/environments/$environment/.git rev-parse --short HEAD 2>/dev/null || echo',
-  $dns_alt_names     = undef,
+  $dns_alt_names     = [],
   $enc               = '',
   $enc_exec          = '',
   $ensure            = 'present',

manifests/server/config.pp

@@ -18,7 +18,7 @@
       $environmentpath_ensure = 'absent'
     }
 
-    if $puppet::server::basemodulepath {
+    if ! empty($puppet::server::basemodulepath) {
       $basemodulepath_ensure = 'present'
     } else {
       $basemodulepath_ensure = 'absent'
@@ -41,7 +41,7 @@
       $manifest_ensure = 'absent'
     }
 
-    if $puppet::server::modulepath {
+    if ! empty($puppet::server::modulepath) {
       $modulepath_ensure = 'present'
     } else {
       $modulepath_ensure = 'absent'
@@ -146,7 +146,7 @@
     value   => $puppet::server::ssl_client_verify_header,
   }
 
-  if $puppet::server::reports {
+  if ! empty($puppet::server::reports) {
     $reports_ensure = 'present'
   } else {
     $reports_ensure = 'absent'
@@ -212,7 +212,7 @@
     value   => $puppet::server::parser,
   }
 
-  if $puppet::server::dns_alt_names {
+  if ! empty($puppet::server::dns_alt_names) {
     $dns_alt_names_ensure = 'present'
   } else {
     $dns_alt_names_ensure = 'absent'
@@ -221,7 +221,7 @@
   ini_setting { 'dns_alt_names':
     ensure  => $dns_alt_names_ensure,
     setting => 'dns_alt_names',
-    value   =>  $puppet::server::dns_alt_names,
+    value   => join(flatten([ $puppet::server::dns_alt_names ]), ', ')
   }
 
   if $puppet::server::autosign {