(PDB-5161) engine: use parse-field instead of string operations

Replace various remaining uses of string operations like splitting a
field on #"\." with parse-field.

Author: rbrw

src/puppetlabs/puppetdb/query_eng/engine.clj

@@ -2062,7 +2062,9 @@
                      "Argument \"{0}\" is incompatible with numeric field \"{1}\"."
                      value (name field))))))
 
-              [[(:or ">" ">=" "<" "<=")  (field :guard #(not (str/includes? %  "."))) _]]
+              [[(:or ">" ">=" "<" "<=")
+                (field :guard #(= (count (parse/parse-field %)) 1))
+                _]]
               (let [col-type (get-in query-context [:projections field :type])]
                 (when-not (or (vec? field)
                               (contains? #{:numeric :timestamp :jsonb-scalar}
@@ -2366,8 +2368,9 @@
                                         :value value}))
 
             [["=" column-name value]]
-            (let [colname (first (str/split column-name #"\."))
-                  cinfo (get-in query-rec [:projections colname])]
+            ;; FIXME: pass parsed representation down
+            (let [[top & path] (parse/parse-field column-name)
+                  cinfo (get-in query-rec [:projections (:name top)])]
               (case (:type cinfo)
                :timestamp
                (map->BinaryExpression {:operator :=
@@ -2384,7 +2387,7 @@
                                        :value (facts/factpath-to-string value)})
 
                :queryable-json
-               (if (string/includes? column-name "[")
+               (if (some #(= ::parse/indexed-field-part (:kind %)) path)
                  (map->JsonbPathBinaryExpression {:field column-name
                                                   :column-data cinfo
                                                   :value value
@@ -2442,8 +2445,9 @@
                                                                    (map str value))})))
 
             [[(op :guard #{">" "<" ">=" "<="}) column-name value]]
-            (let [colname (first (str/split column-name #"\."))
-                  {:keys [type] :as cinfo} (get-in query-rec [:projections colname])]
+            ;; FIXME: pass parsed representation down
+            (let [[top & path] (parse/parse-field column-name)
+                  {:keys [type] :as cinfo} (get-in query-rec [:projections (:name top)])]
               (cond
                 (= :timestamp type)
                 (map->BinaryExpression {:operator (keyword op)
@@ -2498,8 +2502,9 @@
                 (map->NullExpression {:column cinfo :null? value})))
 
             [["~" column-name value]]
-            (let [colname (first (str/split column-name #"\."))
-                  cinfo (get-in query-rec [:projections colname])]
+            ;; FIXME: pass parsed representation down
+            (let [[top] (parse/parse-field column-name)
+                  cinfo (get-in query-rec [:projections (:name top)])]
               (case (:type cinfo)
                 :array
                 (map->ArrayRegexExpression {:column cinfo :value value})