Eta reduction gives better generated code

Author: mlang

src/Data/Bifoldable.purs

@@ -107,7 +107,7 @@ bifoldMapDefaultR
   -> (b -> m)
   -> p a b
   -> m
-bifoldMapDefaultR f g p = bifoldr (append <<< f) (append <<< g) mempty p
+bifoldMapDefaultR f g = bifoldr (append <<< f) (append <<< g) mempty
 
 -- | A default implementation of `bifoldMap` using `bifoldl`.
 -- |
@@ -120,7 +120,7 @@ bifoldMapDefaultL
   -> (b -> m)
   -> p a b
   -> m
-bifoldMapDefaultL f g p = bifoldl (\m a -> m <> f a) (\m b -> m <> g b) mempty p
+bifoldMapDefaultL f g = bifoldl (\m a -> m <> f a) (\m b -> m <> g b) mempty
 
 
 -- | Fold a data structure, accumulating values in a monoidal type.

src/Data/Bitraversable.purs

@@ -88,7 +88,7 @@ bisequenceDefault
    . (Bitraversable t, Applicative f)
   => t (f a) (f b)
   -> f (t a b)
-bisequenceDefault t = bitraverse id id t
+bisequenceDefault = bitraverse id id
 
 -- | Traverse a data structure, accumulating effects and results using an `Applicative` functor.
 bifor

src/Data/Foldable.purs

@@ -96,7 +96,7 @@ foldMapDefaultR
    => (a -> m)
    -> f a
    -> m
-foldMapDefaultR f xs = foldr (\x acc -> f x <> acc) mempty xs
+foldMapDefaultR f = foldr (\x acc -> f x <> acc) mempty
 
 -- | A default implementation of `foldMap` using `foldl`.
 -- |
@@ -108,7 +108,7 @@ foldMapDefaultL
    => (a -> m)
    -> f a
    -> m
-foldMapDefaultL f xs = foldl (\acc x -> f x <> acc) mempty xs
+foldMapDefaultL f = foldl (\acc x -> f x <> acc) mempty
 
 instance foldableArray :: Foldable Array where
   foldr = foldrArray
@@ -240,12 +240,12 @@ or = any id
 -- | `all f` is the same as `and <<< map f`; map a function over the structure,
 -- | and then get the conjunction of the results.
 all :: forall a b f. (Foldable f, HeytingAlgebra b) => (a -> b) -> f a -> b
-all p = alaF Conj foldMap p
+all = alaF Conj foldMap
 
 -- | `any f` is the same as `or <<< map f`; map a function over the structure,
 -- | and then get the disjunction of the results.
 any :: forall a b f. (Foldable f, HeytingAlgebra b) => (a -> b) -> f a -> b
-any p = alaF Disj foldMap p
+any = alaF Disj foldMap
 
 -- | Find the sum of the numeric values in a data structure.
 sum :: forall a f. (Foldable f, Semiring a) => f a -> a

src/Data/Traversable.purs

@@ -64,7 +64,7 @@ sequenceDefault
    . (Traversable t, Applicative m)
   => t (m a)
   -> m (t a)
-sequenceDefault tma = traverse id tma
+sequenceDefault = traverse id
 
 instance traversableArray :: Traversable Array where
   traverse = traverseArrayImpl apply map pure