Skip to content

ordNumber is not compatible with IEEE 754 floats #306

@anttih

Description

@anttih

purs compiles the following:

(1.0 < nan) == false

to

1.0 < nan === false

but if we instead go through the Ord API we can observe different behavior that is not compatible with IEEE 754:

compare 1.0 nan == GT

In addition to just being wrong, the more practical issue is that any alternative backend that does not inline the use of comparison operators to operators that implement IEEE 754 correctly won't pass the prelude test suite. For example backend-es does not pass the prelude test suite.

One simple fix that was floated around in Discord is to just remove the tests using NaN from the test suite and leave the behavior undefined.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions