refactor: revent not needed changes

Author: Szymon.Poltorak

packages/angular-mcp-server/src/lib/tools/ds/component-contract/builder/build-component-contract.tool.ts

@@ -10,7 +10,6 @@ import {
 } from '../shared/utils/contract-file-ops.js';
 import { ContractResult } from './models/types.js';
 import { resolveCrossPlatformPath } from '../../shared/utils/cross-platform-path.js';
-import { validateAndNormalizeComponentName } from '../../shared/utils/component-validation.js';
 
 interface BuildComponentContractOptions extends BaseHandlerOptions {
   directory: string;
@@ -26,12 +25,13 @@ export const buildComponentContractHandler = createHandler<
 >(
   buildComponentContractSchema.name,
   async (params, { cwd, workspaceRoot }) => {
-    const { directory, templateFile, styleFile, typescriptFile } = params;
-
-    // Normalize component name at handler entry point
-    const dsComponentName = validateAndNormalizeComponentName(
-      params.dsComponentName,
-    );
+    const {
+      directory,
+      templateFile,
+      styleFile,
+      typescriptFile,
+      dsComponentName,
+    } = params;
 
     const effectiveTemplatePath = resolveCrossPlatformPath(
       directory,

packages/angular-mcp-server/src/lib/tools/ds/component-contract/diff/diff-component-contract.tool.ts

@@ -9,10 +9,7 @@ import {
 import { diffComponentContractSchema } from './models/schema.js';
 import type { DomPathDictionary } from '../shared/models/types.js';
 import { loadContract } from '../shared/utils/contract-file-ops.js';
-import {
-  componentNameToKebabCase,
-  validateAndNormalizeComponentName,
-} from '../../shared/utils/component-validation.js';
+import { componentNameToKebabCase } from '../../shared/utils/component-validation.js';
 import { basename } from 'node:path';
 import {
   consolidateAndPruneRemoveOperationsWithDeduplication,
@@ -38,11 +35,6 @@ export const diffComponentContractHandler = createHandler<
 >(
   diffComponentContractSchema.name,
   async (params, { workspaceRoot }) => {
-    // Normalize component name at handler entry point
-    const dsComponentName = validateAndNormalizeComponentName(
-      params.dsComponentName,
-    );
-
     const effectiveBeforePath = resolveCrossPlatformPath(
       params.directory,
       params.contractBeforePath,
@@ -65,7 +57,7 @@ export const diffComponentContractHandler = createHandler<
     const diffData = {
       before: effectiveBeforePath,
       after: effectiveAfterPath,
-      dsComponentName: dsComponentName,
+      dsComponentName: params.dsComponentName,
       timestamp: new Date().toISOString(),
       domPathDictionary: domPathDict.paths,
       changes: groupedChanges,
@@ -76,7 +68,7 @@ export const diffComponentContractHandler = createHandler<
     const normalizedDiffData = normalizePathsInObject(diffData, workspaceRoot);
 
     // Create component-specific diffs directory
-    const componentKebab = componentNameToKebabCase(dsComponentName);
+    const componentKebab = componentNameToKebabCase(params.dsComponentName);
     const diffDir = resolveCrossPlatformPath(
       workspaceRoot,
       `.cursor/tmp/contracts/${componentKebab}/diffs`,

packages/angular-mcp-server/src/lib/tools/ds/component/get-deprecated-css-classes.tool.ts

@@ -5,7 +5,6 @@ import {
   COMMON_ANNOTATIONS,
 } from '../shared/models/schema-helpers.js';
 import { getDeprecatedCssClasses } from './utils/deprecated-css-helpers.js';
-import { validateAndNormalizeComponentName } from '../shared/utils/component-validation.js';
 
 interface DeprecatedCssClassesOptions {
   componentName: string;
@@ -29,12 +28,8 @@ export const getDeprecatedCssClassesHandler = createHandler<
 >(
   getDeprecatedCssClassesSchema.name,
   async ({ componentName }, { cwd, deprecatedCssClassesPath }) => {
-    // Normalize component name at handler entry point
-    const normalizedComponentName =
-      validateAndNormalizeComponentName(componentName);
-
     return getDeprecatedCssClasses(
-      normalizedComponentName,
+      componentName,
       deprecatedCssClassesPath,
       cwd,
     );

packages/angular-mcp-server/src/lib/tools/ds/component/get-ds-component-data.tool.ts

@@ -7,7 +7,7 @@ import { COMMON_ANNOTATIONS } from '../shared/models/schema-helpers.js';
 import { getComponentPathsInfo } from './utils/paths-helpers.js';
 import { getComponentDocPathsForName } from './utils/doc-helpers.js';
 import {
-  validateAndNormalizeComponentName,
+  validateComponentName,
   componentNameToKebabCase,
 } from '../shared/utils/component-validation.js';
 import { resolveCrossPlatformPath } from '../shared/utils/cross-platform-path.js';
@@ -114,11 +114,12 @@ export const getDsComponentDataHandler = createHandler<
   DsComponentData
 >(
   getDsComponentDataToolSchema.name,
-  async (params, { cwd, uiRoot, storybookDocsRoot }) => {
-    const { sections = ['all'] } = params;
-    let { componentName } = params;
+  async (
+    { componentName, sections = ['all'] },
+    { cwd, uiRoot, storybookDocsRoot },
+  ) => {
     try {
-      componentName = validateAndNormalizeComponentName(componentName);
+      validateComponentName(componentName);
 
       const includeAll = sections.includes('all');
       const includeImplementation =

packages/angular-mcp-server/src/lib/tools/ds/project/get-project-dependencies.tool.ts

@@ -8,7 +8,7 @@ import {
   COMMON_ANNOTATIONS,
 } from '../shared/models/schema-helpers.js';
 import { analyzeProjectDependencies } from './utils/dependencies-helpers.js';
-import { validateAndNormalizeComponentName } from '../shared/utils/component-validation.js';
+import { validateComponentName } from '../shared/utils/component-validation.js';
 
 interface ProjectDependenciesOptions extends BaseHandlerOptions {
   directory: string;
@@ -42,11 +42,10 @@ export const getProjectDependenciesHandler = createHandler<
 >(
   getProjectDependenciesSchema.name,
   async (params, { cwd, workspaceRoot, uiRoot }) => {
-    const { directory } = params;
-    let { componentName } = params;
+    const { directory, componentName } = params;
 
     if (componentName) {
-      componentName = validateAndNormalizeComponentName(componentName);
+      validateComponentName(componentName);
     }
 
     return await analyzeProjectDependencies(

packages/angular-mcp-server/src/lib/tools/ds/project/report-deprecated-css.tool.ts

@@ -5,7 +5,6 @@ import {
   BaseHandlerOptions,
   RESULT_FORMATTERS,
 } from '../shared/utils/handler-helpers.js';
-import { validateAndNormalizeComponentName } from '../shared/utils/component-validation.js';
 import {
   createDirectoryComponentSchema,
   COMMON_ANNOTATIONS,
@@ -41,12 +40,7 @@ export const reportDeprecatedCssHandler = createHandler<
 >(
   reportDeprecatedCssSchema.name,
   async (params, { cwd, deprecatedCssClassesPath }) => {
-    const { directory } = params;
-
-    // Normalize component name at handler entry point
-    const componentName = validateAndNormalizeComponentName(
-      params.componentName,
-    );
+    const { directory, componentName } = params;
 
     const deprecated = getDeprecatedCssClasses(
       componentName,

packages/angular-mcp-server/src/lib/tools/ds/report-violations/report-violations.tool.ts

@@ -3,7 +3,6 @@ import {
   BaseHandlerOptions,
   RESULT_FORMATTERS,
 } from '../shared/utils/handler-helpers.js';
-import { validateAndNormalizeComponentName } from '../shared/utils/component-validation.js';
 import {
   createViolationReportingSchema,
   COMMON_ANNOTATIONS,
@@ -37,14 +36,7 @@ export const reportViolationsHandler = createHandler<
     // Default to 'file' grouping if not specified
     const groupBy = params.groupBy || 'file';
 
-    // Normalize component name at handler entry point
-    const normalizedParams = {
-      ...params,
-      componentName: validateAndNormalizeComponentName(params.componentName),
-    };
-
-    const result =
-      await analyzeViolationsBase<ViolationResult>(normalizedParams);
+    const result = await analyzeViolationsBase<ViolationResult>(params);
 
     const formattedContent = formatViolations(result, params.directory, {
       groupBy,

packages/angular-mcp-server/src/lib/tools/ds/shared/utils/component-validation.ts

@@ -1,14 +1,5 @@
 import { COMPONENT_REGEXES } from './regex-helpers.js';
 
-/**
- * Normalizes a component name to ensure it has the "Ds" prefix
- * @param componentName The component name (e.g., "Button" or "DsButton")
- * @returns The normalized component name with "Ds" prefix (e.g., "DsButton")
- */
-export function normalizeComponentName(componentName: string): string {
-  return componentName.startsWith('Ds') ? componentName : `Ds${componentName}`;
-}
-
 /**
  * Validates that a component name is a valid Design System component name
  * Accepts both formats: "Button" and "DsButton"
@@ -29,20 +20,6 @@ export function validateComponentName(
   }
 }
 
-/**
- * Validates and normalizes a component name to ensure it has the "Ds" prefix
- * Accepts both formats: "Button" and "DsButton" but always returns "DsButton"
- * @param componentName The component name to validate and normalize
- * @returns The normalized component name with "Ds" prefix (e.g., "DsButton")
- * @throws Error if the component name is invalid
- */
-export function validateAndNormalizeComponentName(
-  componentName: unknown,
-): string {
-  validateComponentName(componentName);
-  return normalizeComponentName(componentName);
-}
-
 /**
  * Converts a Design System component name to kebab case
  * @param componentName The component name (e.g., "DsButton" or "Button")

packages/angular-mcp-server/src/lib/tools/ds/shared/utils/handler-helpers.ts

@@ -2,10 +2,7 @@ import {
   CallToolRequest,
   CallToolResult,
 } from '@modelcontextprotocol/sdk/types.js';
-import {
-  validateComponentName,
-  validateAndNormalizeComponentName,
-} from './component-validation.js';
+import { validateComponentName } from './component-validation.js';
 import { buildTextResponse, throwError } from './output.utils.js';
 import * as process from 'node:process';
 
@@ -47,25 +44,6 @@ export function validateCommonInputs(params: BaseHandlerOptions): void {
   }
 }
 
-/**
- * Validates and normalizes common input parameters, returning normalized params
- */
-export function validateAndNormalizeCommonInputs<T extends BaseHandlerOptions>(
-  params: T,
-): T {
-  if (params.componentName) {
-    params.componentName = validateAndNormalizeComponentName(
-      params.componentName,
-    );
-  }
-
-  if (params.directory && typeof params.directory !== 'string') {
-    throw new Error('Directory parameter is required and must be a string');
-  }
-
-  return params;
-}
-
 /**
  * Sets up common environment for handlers
  */