fix: avoid false positive when module-level names match class-level names

- Add scope comparision to avoid module-level constants to be incorrectly
classified as variables when a class-level attribute with the same name exists

Closes #10719

Author: joao-faria-dev

doc/whatsnew/fragments/10719.false_positive

@@ -0,0 +1,3 @@
+Fixed false positive for ``invalid-name`` where module-level constants were incorrectly classified as variables when a class-level attribute with the same name exists.
+
+Closes #10719

pylint/checkers/utils.py

@@ -1843,28 +1843,48 @@ def is_sys_guard(node: nodes.If) -> bool:
     return False
 
 
+def _is_node_in_same_scope(
+    candidate: nodes.NodeNG, node_scope: nodes.LocalsDictNodeNG
+) -> bool:
+    if isinstance(candidate, (nodes.ClassDef, nodes.FunctionDef)):
+        return bool(
+            candidate.parent is not None and candidate.parent.scope() == node_scope
+        )
+    return bool(candidate.scope() == node_scope)
+
+
 def is_reassigned_before_current(node: nodes.NodeNG, varname: str) -> bool:
     """Check if the given variable name is reassigned in the same scope before the
     current node.
     """
-    return any(
-        a.name == varname and a.lineno < node.lineno
-        for a in node.scope().nodes_of_class(
-            (nodes.AssignName, nodes.ClassDef, nodes.FunctionDef)
-        )
-    )
+    node_scope = node.scope()
+    node_lineno = node.lineno
+    if node_lineno is None:
+        return False
+    for a in node_scope.nodes_of_class(
+        (nodes.AssignName, nodes.ClassDef, nodes.FunctionDef)
+    ):
+        if a.name == varname and a.lineno is not None and a.lineno < node_lineno:
+            if _is_node_in_same_scope(a, node_scope):
+                return True
+    return False
 
 
 def is_reassigned_after_current(node: nodes.NodeNG, varname: str) -> bool:
     """Check if the given variable name is reassigned in the same scope after the
     current node.
     """
-    return any(
-        a.name == varname and a.lineno > node.lineno
-        for a in node.scope().nodes_of_class(
-            (nodes.AssignName, nodes.ClassDef, nodes.FunctionDef)
-        )
-    )
+    node_scope = node.scope()
+    node_lineno = node.lineno
+    if node_lineno is None:
+        return False
+    for a in node_scope.nodes_of_class(
+        (nodes.AssignName, nodes.ClassDef, nodes.FunctionDef)
+    ):
+        if a.name == varname and a.lineno is not None and a.lineno > node_lineno:
+            if _is_node_in_same_scope(a, node_scope):
+                return True
+    return False
 
 
 def is_deleted_after_current(node: nodes.NodeNG, varname: str) -> bool:

tests/checkers/unittest_utils.py

@@ -520,3 +520,32 @@ def test_is_typing_member() -> None:
     )
     assert not utils.is_typing_member(code[0], ("Literal",))
     assert not utils.is_typing_member(code[1], ("Literal",))
+
+
+def test_is_reassigned_after_current_requires_isinstance_check() -> None:
+    tree = astroid.parse(
+        """
+    CONSTANT = 1
+
+    def global_function_assign():
+        global CONSTANT
+        def CONSTANT():
+            pass
+        CONSTANT()
+    """
+    )
+    func = tree.body[1]
+    global_stmt = func.body[0]
+    nested_func = func.body[1]
+
+    assert isinstance(global_stmt, nodes.Global)
+    assert isinstance(nested_func, nodes.FunctionDef)
+
+    node_scope = global_stmt.scope()
+
+    assert nested_func.scope() == nested_func
+    assert nested_func.scope() != node_scope
+
+    assert nested_func.parent.scope() == node_scope
+
+    assert utils.is_reassigned_after_current(global_stmt, "CONSTANT") is True

tests/functional/c/const_class_attribute_same_name.py

@@ -0,0 +1,14 @@
+"""Test module-level constants with class attribute same name
+Regression test for #10719.
+"""
+# pylint: disable=missing-docstring, too-few-public-methods, redefined-builtin
+
+
+class Theme:
+    INPUT = ">>> "
+
+
+INPUT = Theme()
+input = Theme()
+OUTPUT = Theme()
+output = Theme()

tests/functional/n/no/no_dummy_redefined.py

@@ -1,4 +1,5 @@
 """Make sure warnings about redefinitions do not trigger for dummy variables."""
+# pylint: disable=invalid-name
 
 
 _, INTERESTING = 'a=b'.split('=')

tests/functional/n/no/no_dummy_redefined.txt

@@ -1 +1 @@
-redefined-outer-name:11:4:11:9:clobbering:Redefining name 'value' from outer scope (line 6):UNDEFINED
+redefined-outer-name:12:4:12:9:clobbering:Redefining name 'value' from outer scope (line 7):UNDEFINED