Skip to content

Commit 59f863e

Browse files
committed
Rename tempd to wheel_directory for clarity
1 parent a0467a3 commit 59f863e

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

src/pip/_internal/operations/build/wheel.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,25 +14,25 @@ def build_wheel_pep517(
1414
name: str,
1515
backend: BuildBackendHookCaller,
1616
metadata_directory: str,
17-
tempd: str,
17+
wheel_directory: str,
1818
) -> str | None:
1919
"""Build one InstallRequirement using the PEP 517 build process.
2020
2121
Returns path to wheel if successfully built. Otherwise, returns None.
2222
"""
2323
assert metadata_directory is not None
2424
try:
25-
logger.debug("Destination directory: %s", tempd)
25+
logger.debug("Destination directory: %s", wheel_directory)
2626

2727
runner = runner_with_spinner_message(
2828
f"Building wheel for {name} (pyproject.toml)"
2929
)
3030
with backend.subprocess_runner(runner):
3131
wheel_name = backend.build_wheel(
32-
wheel_directory=tempd,
32+
wheel_directory=wheel_directory,
3333
metadata_directory=metadata_directory,
3434
)
3535
except Exception:
3636
logger.error("Failed building wheel for %s", name)
3737
return None
38-
return os.path.join(tempd, wheel_name)
38+
return os.path.join(wheel_directory, wheel_name)

src/pip/_internal/operations/build/wheel_editable.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,23 +14,23 @@ def build_wheel_editable(
1414
name: str,
1515
backend: BuildBackendHookCaller,
1616
metadata_directory: str,
17-
tempd: str,
17+
wheel_directory: str,
1818
) -> str | None:
1919
"""Build one InstallRequirement using the PEP 660 build process.
2020
2121
Returns path to wheel if successfully built. Otherwise, returns None.
2222
"""
2323
assert metadata_directory is not None
2424
try:
25-
logger.debug("Destination directory: %s", tempd)
25+
logger.debug("Destination directory: %s", wheel_directory)
2626

2727
runner = runner_with_spinner_message(
2828
f"Building editable for {name} (pyproject.toml)"
2929
)
3030
with backend.subprocess_runner(runner):
3131
try:
3232
wheel_name = backend.build_editable(
33-
wheel_directory=tempd,
33+
wheel_directory=wheel_directory,
3434
metadata_directory=metadata_directory,
3535
)
3636
except HookMissing as e:
@@ -44,4 +44,4 @@ def build_wheel_editable(
4444
except Exception:
4545
logger.error("Failed building editable for %s", name)
4646
return None
47-
return os.path.join(tempd, wheel_name)
47+
return os.path.join(wheel_directory, wheel_name)

src/pip/_internal/operations/build/wheel_legacy.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def build_wheel_legacy(
6464
source_dir: str,
6565
global_options: list[str],
6666
build_options: list[str],
67-
tempd: str,
67+
wheel_directory: str,
6868
) -> str | None:
6969
"""Build one unpacked package using the "legacy" build process.
7070
@@ -89,12 +89,12 @@ def build_wheel_legacy(
8989
setup_py_path,
9090
global_options=global_options,
9191
build_options=build_options,
92-
destination_dir=tempd,
92+
destination_dir=wheel_directory,
9393
)
9494

9595
spin_message = f"Building wheel for {name} (setup.py)"
9696
with open_spinner(spin_message) as spinner:
97-
logger.debug("Destination directory: %s", tempd)
97+
logger.debug("Destination directory: %s", wheel_directory)
9898

9999
try:
100100
output = call_subprocess(
@@ -108,10 +108,10 @@ def build_wheel_legacy(
108108
logger.error("Failed building wheel for %s", name)
109109
return None
110110

111-
names = os.listdir(tempd)
111+
names = os.listdir(wheel_directory)
112112
wheel_path = get_legacy_build_wheel_path(
113113
names=names,
114-
temp_dir=tempd,
114+
temp_dir=wheel_directory,
115115
name=name,
116116
command_args=wheel_args,
117117
command_output=output,

src/pip/_internal/wheel_builder.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ def _build_one_inside_env(
188188
global_options: list[str],
189189
editable: bool,
190190
) -> str | None:
191-
with TemporaryDirectory(dir=output_dir) as temp_dir:
191+
with TemporaryDirectory(dir=output_dir) as wheel_directory:
192192
assert req.name
193193
if req.use_pep517:
194194
assert req.metadata_directory
@@ -206,14 +206,14 @@ def _build_one_inside_env(
206206
name=req.name,
207207
backend=req.pep517_backend,
208208
metadata_directory=req.metadata_directory,
209-
tempd=temp_dir,
209+
wheel_directory=wheel_directory,
210210
)
211211
else:
212212
wheel_path = build_wheel_pep517(
213213
name=req.name,
214214
backend=req.pep517_backend,
215215
metadata_directory=req.metadata_directory,
216-
tempd=temp_dir,
216+
wheel_directory=wheel_directory,
217217
)
218218
else:
219219
wheel_path = build_wheel_legacy(
@@ -222,7 +222,7 @@ def _build_one_inside_env(
222222
source_dir=req.unpacked_source_directory,
223223
global_options=global_options,
224224
build_options=build_options,
225-
tempd=temp_dir,
225+
wheel_directory=wheel_directory,
226226
)
227227

228228
if wheel_path is not None:

0 commit comments

Comments
 (0)