Crashes with classes mod

[tacotexmex]

When using stu's classes mod, the game crashes in-world:

ERROR[Main]: ServerError: AsyncErr: environment_Step: Runtime error from mod 'classes' in callback environment_Step(): ...mods/late/effects.lua:563: attempt to index local 'table' (a number value)
ERROR[Main]: stack traceback:
ERROR[Main]: 	...mods/late/effects.lua:563: in function 'set_physics_override'
ERROR[Main]: 	...mods/classes/classes/classes.lua:49: in function 'update_player_visuals'
ERROR[Main]: 	...mods/classes/classes/classes.lua:117: in function 'func'
ERROR[Main]: 	...minetest.app/Contents/Resources/builtin/common/after.lua:18: in function <...minetest.app/Contents/Resources/builtin/common/after.lua:4>
ERROR[Main]: 	...inetest.app/Contents/Resources/builtin/game/register.lua:419: in function <...inetest.app/Contents/Resources/builtin/game/register.lua:399>
ERROR[Main]: stack traceback:

I guess that "awful hack" isn't able to catch whatever classes is doing. 😉

Classes runs

minetest.after(1, function(player)
	classes:update_player_visuals(player)
end, player)

on joining players, and update_player_visuals in itself does:

classes.update_player_visuals = function(self, player)
	if not player then
		return
	end
	local name = player:get_player_name()
	local class = classes.class[name]
	local properties = classes.properties[class]
	local mesh = ""
	local texture = properties.texture
	mesh = mesh..properties.mesh
	player:set_properties({
		visual = "mesh",
		mesh = mesh,
		collisionbox = properties.collisionbox,
		visual_size = {x=1, y=1},
	})
	if not has_skin_changer then
		player:set_properties({textures={texture}})
	end 
	local physics = properties.physics
	player:set_physics_override(physics.speed, physics.jump, physics.gravity)
	player:set_armor_groups(properties.armor_groups)
end

Seems to me that late and classes competes for player properties somehow. Can it be mitigated? Is classes the faulty mod in this case?

If they're really incompatible with each other I can just write my own class mod, but then how does LATE's core:physics work and how can I modify it?

[pyrollo]

Thanks for this detailled report !

It seems that classes uses the old, non-table format set_physics_override. This format is not documented anymore in the API documentation but it is not a problem to manage it also.

[pyrollo]

Commit 08869ab should solve the issue. [EDITED]

[tacotexmex]

Thanks for trying to solve it from the LATE side. Again, only if it’s legitimate. Otherwise I can roll my own or fork classes with the necessary changes, no need to support random legacy mods per se. :)

Regardless I’ll test this fix first.

[tacotexmex]

Alright, the combination of LATE and classes works insofar that the player properties from classes can coexist with LATE initially but switching classes doesn't work any more. The values just stays the same as from the first applied class.

Now again, that may be due to insufficient coding or depricated methods on classes' part and not necessarily something that should be fixed in LATE. I'm leaning towards writing my own classes mod, but if so I would need some guidance on how to modify the core:physics effect of each player individually. Any advice?

[pyrollo]

My opinion is :
LATE should work with all versions of the API (this should improve other mods integration)
AND
Every old mod should be updated to use the correct version of the API

I don't know yet why classes don't work as expected with LATE. The idea is to override set_physics_override so any changes made on player physics by other mods would be taken in account by LATE. Investigation to be done :)