Spaces in tags should be replaced with underscores

[salimfadhley]

Good (bad) example, we have one tag which is "project manager", this should probably be rendered as "project_manager"

[stestagg]

I don't know.
Does the '_' actually help with anything? My gut says that unless the space causes unsolvable problems, then we should keep it more readable?

[salimfadhley]

It just makes the URLs look horrid with all the %20s in there.

[stestagg]

Aah, that's a good point, some other thoughts then:

1. In my opinion, the on-page formatting should always trump URL niceness in this sort of situation. But I don't mind being overruled on that
2. The convention is to encode spaces in urls with '+' rather than %20. To get that to work we would have to change some things in the tagger (not ideal), but then the URLs look nicer, and things act more normally
3. We could alternately render the tags with spaces, but encode the filenames (hence urls) with '_', giving us the best of both worlds. This should be simple to do with a tag filter, but the filter would have to be applied everywhere we're outputting tags (not that many tbh)

[stestagg]

OK, so that was a ramble, but the tl;dr is:

I propose:

1. When doing tag normalization in our plugin, convert whitespace to underscore
2. When rendering, convert underscore to ' ' (so it's easier to read)

[salimfadhley]

okay, will do.

[lordmauve]

My preference is for hyphenated tags. Works for me visually and in URLs.

On Tue, 17 Mar 2015 22:16 Salim Fadhley notifications@github.com wrote:

okay, will do.

—
Reply to this email directly or view it on GitHub
#40 (comment).