-
Notifications
You must be signed in to change notification settings - Fork 380
Build PERF for HQQ vs. Affine #3403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3403
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
❌ 🤖 pytorchbot command failed: |
|
@pytorchbot label "topic: performance" |
| @property | ||
| def max_gen_toks(self): | ||
| return 50 | ||
| return 512 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is updated because the GSM8K task is CoT reasoning (long-context)
|
cc @metascroy can you take a look into this? I will move to E2E support for SINQ after this PR as we talked with #3156 (comment); we can add SINQ to this e2e benchmark I feel. |
|
Thanks! The unit test looks good to me. I'll let @jainapurva review the benchmark script, as I'm less familiar with that part of the codebase and if there are coding standards that are usually followed. |
|
intx is targeting mobile right? so testing performance on server doesn't seem to be helpful? |
@jerryzh168 Even though we don't test in AP device, testing performance would be helpful because there are only outdated CUDA benchmarks for HQQ:
. For the future plan, I only used up-to-date functions like |
Summary:
Build a benchmark module for affine (base) vs. HQQ. Both workflows don't require calibration flow, which means there is no need to compute element-wise ops. The HQQ unit test is added because there was only an e2e test.
Test Plan:
PERF result:
Related Issue/PR: #3156