From eec1f6bc0af31cf4e34c235cbdf264b78c000894 Mon Sep 17 00:00:00 2001 From: Sam Anklesaria Date: Fri, 1 Aug 2025 17:14:02 +0000 Subject: [PATCH 1/4] Remove deprecated functionality from smoke_test --- test/smoke_test/smoke_test.py | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index 9d113a7edc..b472d248cd 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -6,28 +6,14 @@ def base_smoke_test(): import torchaudio # noqa: F401 - import torchaudio.compliance.kaldi # noqa: F401 import torchaudio.datasets # noqa: F401 import torchaudio.functional # noqa: F401 import torchaudio.models # noqa: F401 - import torchaudio.pipelines # noqa: F401 - import torchaudio.sox_effects # noqa: F401 import torchaudio.transforms # noqa: F401 import torchaudio.utils # noqa: F401 - -def ffmpeg_test(): - from torchaudio.io import StreamReader # noqa: F401 - - -def _run_smoke_test(check_ffmpeg): +def _run_smoke_test(): base_smoke_test() - - if not check_ffmpeg: - print("Skipping ffmpeg test.") - else: - ffmpeg_test() - print("Smoke test passed.") @@ -38,14 +24,13 @@ def main(args=None) -> None: logging.basicConfig(format="%(levelname)s: %(message)s", level=logging.DEBUG) _chdir() - _run_smoke_test(options.ffmpeg) + _run_smoke_test() def _parse_args(args): parser = argparse.ArgumentParser() # Warning: Please note this option should not be widely used, only use it when absolutely necessary - parser.add_argument("--no-ffmpeg", dest="ffmpeg", action="store_false") parser.add_argument("--debug", action="store_true", help="Enable debug logging.") return parser.parse_args(args) From 458bbe529e84d84bf13901b707d85362ff2f0b5e Mon Sep 17 00:00:00 2001 From: Sam Anklesaria Date: Fri, 1 Aug 2025 17:16:33 +0000 Subject: [PATCH 2/4] Remove smoke_test_no_ffmpeg --- test/smoke_test/smoke_test_no_ffmpeg.py | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 test/smoke_test/smoke_test_no_ffmpeg.py diff --git a/test/smoke_test/smoke_test_no_ffmpeg.py b/test/smoke_test/smoke_test_no_ffmpeg.py deleted file mode 100644 index 670f27aaa1..0000000000 --- a/test/smoke_test/smoke_test_no_ffmpeg.py +++ /dev/null @@ -1,3 +0,0 @@ -from smoke_test import main - -main(["--no-ffmpeg"]) From 8f4164b7f21b6b35a280c07e320e4ea0b687cd09 Mon Sep 17 00:00:00 2001 From: Sam Anklesaria Date: Mon, 4 Aug 2025 19:02:12 +0000 Subject: [PATCH 3/4] Add back parser argument for no-ffmpeg for backward compat --- test/smoke_test/smoke_test.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/smoke_test/smoke_test.py b/test/smoke_test/smoke_test.py index b472d248cd..c8c22a463c 100644 --- a/test/smoke_test/smoke_test.py +++ b/test/smoke_test/smoke_test.py @@ -9,6 +9,7 @@ def base_smoke_test(): import torchaudio.datasets # noqa: F401 import torchaudio.functional # noqa: F401 import torchaudio.models # noqa: F401 + import torchaudio.pipelines # noqa: F401 import torchaudio.transforms # noqa: F401 import torchaudio.utils # noqa: F401 @@ -30,7 +31,8 @@ def main(args=None) -> None: def _parse_args(args): parser = argparse.ArgumentParser() - # Warning: Please note this option should not be widely used, only use it when absolutely necessary + # Warning: Please note this option does nothing and only exists for backward compatibility. + parser.add_argument("--no-ffmpeg", dest="ffmpeg", action="store_false") parser.add_argument("--debug", action="store_true", help="Enable debug logging.") return parser.parse_args(args) From 79e09716ec242c7d05e0994dfdc38c98e72b695d Mon Sep 17 00:00:00 2001 From: Sam Anklesaria Date: Tue, 5 Aug 2025 16:49:42 +0000 Subject: [PATCH 4/4] Add back smoke_test_no_ffmpeg --- test/smoke_test/smoke_test_no_ffmpeg.py | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 test/smoke_test/smoke_test_no_ffmpeg.py diff --git a/test/smoke_test/smoke_test_no_ffmpeg.py b/test/smoke_test/smoke_test_no_ffmpeg.py new file mode 100644 index 0000000000..670f27aaa1 --- /dev/null +++ b/test/smoke_test/smoke_test_no_ffmpeg.py @@ -0,0 +1,3 @@ +from smoke_test import main + +main(["--no-ffmpeg"])