Skip to content

Conversation

@shewu-quic
Copy link
Collaborator

@shewu-quic shewu-quic commented Nov 27, 2025

Summary:

  • Prevent dynamic_cast failures caused by separate typeinfo in each library with clang.

cc: @haowhsu-quic

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15999

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Pending, 2 Unrelated Failures

As of commit 9b4866c with merge base 1864fb0 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2025
@shewu-quic shewu-quic marked this pull request as ready for review November 27, 2025 06:16
@shewu-quic
Copy link
Collaborator Author

shewu-quic commented Nov 27, 2025

Hi @cccclai
This PR addresses the dynamic_cast failure encountered with clang in this issue #15734
I will split Qualcomm AI Engine Direct - Support PARSeq in floating point precision into a few PRs.

Could you take a look at this when you have a moment?

Thanks

@shewu-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Nov 27, 2025
@cccclai
Copy link
Contributor

cccclai commented Dec 1, 2025

It seems like a pretty big change and I just recently disable qnn pybind test #15949. Let's make sure it passes internal test and the qnn related CI..

…gle library

Summary:
- Prevent dynamic_cast failures caused by separate typeinfo in each library.
@shewu-quic shewu-quic force-pushed the dev1/hutton/combine_pybind_libraries branch from 8c6e5ff to 92d84f8 Compare December 2, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants