Qualcomm AI Engine Direct - Remove legacy code related to the shared buffer #16000
+38
−160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buffer Summary: - Remove PreRegisterMem, as it is legacy code used for registering custom memory before execution.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16000
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label "release notes: qualcomm" |
pytorch-bot
bot
added
the
release notes: qualcomm
Collaborator
Author
|
Hi @cccclai, This PR addresses the error that occurs when running llama_runner multiple times within a single process. Thanks |
cccclai
reviewed
Dec 1, 2025
| std::unordered_set<CustomMemTensorInfo> custom_mem_tensor_info_set_; | ||
| // After the custom memory is freed, we will ensure that no tensor addresses | ||
| // remain linked to this custom memory. | ||
| std::unordered_map<void*, std::unordered_set<void*>> |
Contributor
There was a problem hiding this comment.
Can you add a comment to describe how custom memory work (like the life cycle and ownership etc) in this stack? I received the question multiple times.
Contributor
|
Also our CI isn't working last week. Can you rebase to see if it's recovered? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
cc: @haowhsu-quic