Skip to content

Conversation

@PetarTerziev-UL
Copy link

@PetarTerziev-UL PetarTerziev-UL commented Nov 27, 2025

Summary

coremltools versions prior to 9.0 did not support Python 3.13. Now executorch uses 9.0, we can finally enable building wheels with Python 3.13.

Fixes #8292

Test plan

Python test suite ran and compared against a dev install of the target branchh in a 3.12 virtual environment.

coremltools versions prior to 9.0 did not support Python 3.13. Now
executorch uses 9.0, we can finally enable building wheels with
Python 3.13.
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 27, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16004

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Unrelated Failure

As of commit 7fbf70d with merge base 3ce840c (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 27, 2025
@PetarTerziev-UL
Copy link
Author

I need to add a "release notes: misc" label, but I don't seem to have the ability to.

@PetarTerziev-UL
Copy link
Author

the tests under examples/models/llama3_2_vision/preprocess hang on a call into AOTInductor when torch nightly is installed.

Need to look into this further.

The Python tests in examples/models/lama3_2_vision/preprocess/test_preprocess
was hanging on MacOS with the previous nightly pinned here when installed with
Python 3.13.
@PetarTerziev-UL
Copy link
Author

the tests under examples/models/llama3_2_vision/preprocess hang on a call into AOTInductor when torch nightly is installed.

Need to look into this further.

Things are better in with a newer nightly build of torch, so I've bumped the pinned version as part of this PR too.

@PetarTerziev-UL PetarTerziev-UL marked this pull request as ready for review December 1, 2025 15:10
@mergennachin mergennachin added ciflow/trunk ciflow/binaries ciflow/binaries/all Release PRs with this label will build wheels for all python versions labels Dec 1, 2025
Copilot finished reviewing on behalf of mergennachin December 1, 2025 20:40
@mergennachin mergennachin added the release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. label Dec 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Python 3.13 support to ExecuTorch now that coremltools 9.0 (which supports Python 3.13) is available. The changes update version constraints, documentation, and CI/CD workflows to enable building wheels for Python 3.13.

Key changes:

  • Update Python version constraint from <3.13 to <3.14 in pyproject.toml
  • Add Python 3.13 to wheel building workflows and documentation
  • Remove Python 3.13 warning from CoreML troubleshooting documentation
  • Update nightly version pin (unrelated maintenance update)

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Add Python 3.13 classifier, update requires-python constraint to <3.14, add py313 to ruff target-version
torch_pin.py Update nightly version from dev20251025 to dev20251124
docs/source/*.md Update Python version requirements from 3.10-3.12 to 3.10-3.13 across multiple documentation files
docs/source/backends/coreml/coreml-troubleshooting.md Remove outdated Python 3.13 compatibility warning
README-wheel.md Add Python 3.13 to list of supported versions
.github/workflows/*.yml Add "3.13" to Python version matrices for wheel building workflows

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

]

# Python dependencies required for use.
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
Copy link

Copilot AI Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is now outdated since Python 3.13 is being supported. Either remove the comment entirely or update it to reflect that the issue was resolved in coremltools 9.0 (e.g., '# coremltools 9.0+ supports python 3.13, see apple/coremltools#2487').

Suggested change
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
# coremltools 9.0+ supports python 3.13, see https://github.com/apple/coremltools/issues/2487

Copilot uses AI. Check for mistakes.
]

# Python dependencies required for use.
# coremltools has issue with python 3.13, see https://github.com/apple/coremltools/issues/2487
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this comment?

@larryliu0820 larryliu0820 added the release notes: misc Miscellaneous label Dec 1, 2025
@larryliu0820
Copy link
Contributor

@PetarTerziev-UL can you please bump the nightly version of pytorch to 1122 instead? I think the nightly job failed to build 1124 nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries/all Release PRs with this label will build wheels for all python versions ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. release notes: misc Miscellaneous

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Python 3.13

3 participants