Skip to content

Conversation

@Christoffer-JL
Copy link

aten::view_copy is now considered no-compute by
the partitioner. This prevents the case
where a partition is left empty if two
view_copy ops cancels each other out,
leaving the partition empty.

This was the case when running
torch_audio_hdemucs_high_musdb(_plus),
which made Vela output an error.

Additionaly, some incorrectly named tests in test_sum have been renamed from view to sum

aten::view_copy is now considered no-compute by
the partitioner. This prevents the case
where a partition is left empty if two
view_copy ops cancels each other out,
leaving the partition empty.

This was the case when running
torch_audio_hdemucs_high_musdb(_plus),
which made Vela output an error.

Additionaly, some incorrectly named tests in test_sum have
been renamed from view to sum

JIRA: MLETORCH-1535

Change-Id: I1fe5175fd560486a064258dee5f0048836022ee1
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16005

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f10d483 with merge base 12d17ef (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla
Copy link

meta-cla bot commented Nov 28, 2025

Hi @Christoffer-JL!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@Christoffer-JL Christoffer-JL marked this pull request as draft November 28, 2025 10:24
@Christoffer-JL Christoffer-JL marked this pull request as ready for review November 28, 2025 10:24
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 1, 2025
@meta-cla
Copy link

meta-cla bot commented Dec 1, 2025

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant