Skip to content

Commit a1f4cc5

Browse files
improved readability of execute steps (#146)
1 parent ada5947 commit a1f4cc5

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
1616

1717
## [Unreleased]
1818
- :rocket: added source maps
19+
- :rocket: improved readability of execute steps
1920

2021
## [2.3.0]
2122
- :rocket: added `I expect {value} css property of every element in {playwrightLocator} collection {validation} {value}` step

src/execute.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {Locator} from "@playwright/test";
88
* @example I execute '$fn' function // fn is function reference
99
* @example I execute 'window.scrollBy(0, 100)' function
1010
*/
11-
When('I execute {value} function', async function (fn: MemoryValue) {
11+
When('I execute {value} function/script', async function (fn: MemoryValue) {
1212
await this.playwright.page.evaluate(await fn.value());
1313
});
1414

@@ -19,7 +19,7 @@ When('I execute {value} function', async function (fn: MemoryValue) {
1919
* @example I execute '$fn' function and save result as 'result' // fn is function reference
2020
* @example I execute 'window.scrollY' function and save result as 'scroll'
2121
*/
22-
When('I execute {value} function and save result as {value}', async function (fn: MemoryValue, memoryKey: MemoryValue) {
22+
When('I execute {value} function/script and save result as {value}', async function (fn: MemoryValue, memoryKey: MemoryValue) {
2323
memoryKey.set(await this.playwright.page.evaluate(await fn.value()));
2424
});
2525

@@ -30,7 +30,7 @@ When('I execute {value} function and save result as {value}', async function (fn
3030
* @example I execute '$fn' function on 'Component > Element' // fn is function reference
3131
* @example I execute 'arguments[0].scrollIntoView()' function on 'Component > Element'
3232
*/
33-
When('I execute {value} function on {playwrightLocator}', async function (fnKey: MemoryValue, locator: Locator) {
33+
When('I execute {value} function/script on {playwrightLocator}', async function (fnKey: MemoryValue, locator: Locator) {
3434
let fn = await fnKey.value();
3535
if (typeof fn === 'string') {
3636
fn = new Function('return ' + fn)
@@ -46,7 +46,7 @@ When('I execute {value} function on {playwrightLocator}', async function (fnKey:
4646
* @example I execute 'arguments[0].innerText' function on 'Component > Element' and save result as 'innerText'
4747
*/
4848
When(
49-
'I execute {value} function on {playwrightLocator} and save result as {value}',
49+
'I execute {value} function/script on {playwrightLocator} and save result as {value}',
5050
async function (fnKey: MemoryValue, locator: Locator, memoryKey: MemoryValue) {
5151
let fn = await fnKey.value();
5252
if (typeof fn === 'string') {

test-e2e/features/execute.feature

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Feature: execute
88
Then I expect 'value' property of 'Input' to be equal 'some value'
99

1010
Scenario: execute function
11-
When I execute '$setInputValue' function
11+
When I execute '$setInputValue' script
1212
Then I expect 'value' property of 'Input' to be equal 'some value'
1313

1414
Scenario: execute function and save result plain text
@@ -18,7 +18,7 @@ Feature: execute
1818

1919
Scenario: execute function from memory and save result plain text
2020
When I click 'Button'
21-
When I execute '$getActionInnerText' function and save result as 'innerText'
21+
When I execute '$getActionInnerText' script and save result as 'innerText'
2222
Then I expect '$innerText' memory value to be equal 'click'
2323

2424
Scenario: execute function on element plain text
@@ -30,7 +30,7 @@ Feature: execute
3030
Then I expect text of 'Action' to be equal 'click'
3131

3232
Scenario: execute function on element plain text and save result
33-
When I execute 'arguments[0].innerText' function on 'Button' and save result as 'buttonInnerText'
33+
When I execute 'arguments[0].innerText' script on 'Button' and save result as 'buttonInnerText'
3434
Then I expect '$buttonInnerText' memory value to be equal 'Click Me!'
3535

3636
Scenario: execute function on element and save result

0 commit comments

Comments
 (0)