Skip to content

Remove access of .data field on abstract types#57

Merged
Krastanov merged 3 commits intoqojulia:mainfrom
akirakyle:data-getproperty
Jun 4, 2025
Merged

Remove access of .data field on abstract types#57
Krastanov merged 3 commits intoqojulia:mainfrom
akirakyle:data-getproperty

Conversation

@akirakyle
Copy link
Member

Fixes #12 for .data field access. Implementing #40 will fix instances of basis{_l,_r} access.

@akirakyle akirakyle requested a review from Krastanov May 4, 2025 23:51
@codecov
Copy link

codecov bot commented May 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (f9171c6) to head (4f3571a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/julia_base.jl 0.00% 5 Missing ⚠️
src/julia_linalg.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   34.66%   35.15%   +0.48%     
==========================================
  Files          15       15              
  Lines         424      421       -3     
==========================================
+ Hits          147      148       +1     
+ Misses        277      273       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Member

I added a small comment explaining the custom error functions because they confused me a bit. Thanks for submitting this. I will merge this and the related one shortly.

@Krastanov Krastanov merged commit 6a0001c into qojulia:main Jun 4, 2025
5 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a bunch of methods acting on abstract types assume internal layout for these types

2 participants