Remove access of .data field on abstract types#57
Merged
Krastanov merged 3 commits intoqojulia:mainfrom Jun 4, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 34.66% 35.15% +0.48%
==========================================
Files 15 15
Lines 424 421 -3
==========================================
+ Hits 147 148 +1
+ Misses 277 273 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
abc58fa to
84fdf01
Compare
Member
|
I added a small comment explaining the custom error functions because they confused me a bit. Thanks for submitting this. I will merge this and the related one shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12 for
.datafield access. Implementing #40 will fix instances ofbasis{_l,_r}access.