Skip to content

Define tensor(states::StateVector...) = reduce(tensor, states) method#60

Merged
apkille merged 2 commits intoqojulia:mainfrom
apkille:tensor
Jun 26, 2025
Merged

Define tensor(states::StateVector...) = reduce(tensor, states) method#60
apkille merged 2 commits intoqojulia:mainfrom
apkille:tensor

Conversation

@apkille
Copy link
Collaborator

@apkille apkille commented Jun 6, 2025

Very small addition, but it's something needed to avoid a couple of failing tests in my incoming Gabs-QSymbolics integration PR.

@apkille apkille requested a review from Krastanov June 6, 2025 22:02
@codecov
Copy link

codecov bot commented Jun 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.48%. Comparing base (4a3aa74) to head (7ab6670).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/tensor.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   33.33%   33.48%   +0.15%     
==========================================
  Files          15       15              
  Lines         441      442       +1     
==========================================
+ Hits          147      148       +1     
  Misses        294      294              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Krastanov
Copy link
Member

@apkille any idea about the failing tests?

@apkille
Copy link
Collaborator Author

apkille commented Jun 22, 2025

@Krastanov it looks like some compatibility requirement downstream is the issue, but I'm not really sure why that is a problem here

@Krastanov Krastanov closed this Jun 26, 2025
@Krastanov Krastanov reopened this Jun 26, 2025
@Krastanov
Copy link
Member

Please check that if there are Breakage tests that fail, it is not a "real" issue, rather just an annoyance due to how breakage is internally dev-ing a bunch of stuff.

If QuantumSavory is failing, that is not a blocker.

If that is good, feel free to merge and make a new release.

Copy link
Member

@Krastanov Krastanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, check failing breakage tests, see inline comment above

@apkille
Copy link
Collaborator Author

apkille commented Jun 26, 2025

It's not a real issue, will merge shortly.

@apkille apkille merged commit cee7217 into qojulia:main Jun 26, 2025
17 of 27 checks passed
@apkille apkille deleted the tensor branch June 26, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants