Skip to content

Commit 29485b6

Browse files
authored
fix error prone (#22)
1 parent f3d0fa8 commit 29485b6

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

Packages/com.quabug.any-processor/CodeGen/PostProcessorReflectionImporterProvider.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ public IReflectionImporter GetReflectionImporter(ModuleDefinition module)
1414
class PostProcessorReflectionImporter : DefaultReflectionImporter
1515
{
1616
private const string SystemPrivateCoreLib = "System.Private.CoreLib";
17-
private AssemblyNameReference _correctCorlib;
17+
private readonly AssemblyNameReference _correctCorlib;
1818

1919
public PostProcessorReflectionImporter(ModuleDefinition module) : base(module)
2020
{

Packages/com.quabug.any-serialize/CodeGen/SerializeTypeSearcher.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
using AnyProcessor.CodeGen;
55
using JetBrains.Annotations;
66
using Mono.Cecil;
7-
using Mono.Cecil.Rocks;
87
using OneShot;
98

109
namespace AnySerialize.CodeGen

Packages/com.quabug.any-serialize/Runtime/IAnyClass.cs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,16 @@ public interface IReadOnlyAnyClass<out T> : IReadOnlyAny<T>, IAnyClass {}
1212

1313
public static class AnyClassUtility
1414
{
15-
public const BindingFlags DefaultBindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic;
15+
public static readonly BindingFlags DefaultBindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic;
1616

17-
[Pure]
17+
[Pure, ItemNotNull]
1818
public static T[] Reorder<T>(this T[] array, IEnumerable<int> newIndices)
1919
{
2020
var newArray = new T[array.Length];
2121
var index = 0;
2222
foreach (var newIndex in newIndices)
2323
{
24-
if (array[index] == null)
25-
throw new ArgumentException($"element of {nameof(array)} cannot be null", nameof(array));
24+
if (array[index] == null) throw new ArgumentException($"element of {nameof(array)} cannot be null", nameof(array));
2625
newArray[newIndex] = array[index];
2726
index++;
2827
}

0 commit comments

Comments
 (0)