Skip to content
This repository was archived by the owner on Jul 13, 2024. It is now read-only.
This repository was archived by the owner on Jul 13, 2024. It is now read-only.

Logger ArgumentNullException VncServerSession #168

@Varmod

Description

@Varmod

Hi,

I'm running a VncServerSession and when a client disconnects I get a:
System.ArgumentNullException: 'Value cannot be null. (Parameter 'logger')

Stacktrace:
Microsoft.Extensions.Logging.Abstractions.dll!Microsoft.Extensions.Logging.LoggerExtensions.Log(Microsoft.Extensions.Logging.ILogger logger, Microsoft.Extensions.Logging.LogLevel logLevel, Microsoft.Extensions.Logging.EventId eventId, System.Exception exception, string message, object[] args RemoteViewing.dll!RemoteViewing.Vnc.Server.VncServerSession.OnClosed() RemoteViewing.dll!RemoteViewing.Vnc.Server.VncServerSession.ThreadMain() System.Private.CoreLib.dll!System.Threading.Thread.StartCallback()

I use the parameterless VncServerSession constructor that isn't passed a Ilogger implementation.
On a quick glance it looks like OnClosed method is missing a null check for the logger?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions