Skip to content

Fix the Github Actions errors #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plhosk wants to merge 4 commits into
base: gha
Choose a base branch
from
Open

Fix the Github Actions errors #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19cbb26
Bump github flow to java 17
plhosk Oct 23, 2025
415c1f3
Resolve dependency resolution failures
plhosk Oct 23, 2025
03d0ab2
Fix linting issue
plhosk Oct 23, 2025
21d54ba
Address gradle deprecation warning
plhosk Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:

steps:
- uses: actions/checkout@v4
- name: set up JDK 11
- name: set up JDK 17
uses: actions/setup-java@v4
with:
java-version: '11'
java-version: '17'
distribution: 'temurin'
cache: gradle

Expand Down
8 changes: 3 additions & 5 deletions app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,14 @@ android {
buildTypes {
release {
minifyEnabled false
proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.txt'
proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.txt'
}
}
namespace 'com.holokenmod'
lint {
disable 'ExpiredTargetSdkVersion'
}
namespace = 'com.holokenmod'
}
repositories {
google()
mavenCentral()
}

dependencies {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/srlee/DLX/DLX.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ private void search(int k)
if (root.GetRight() == root)
{
foundsolution = new ArrayList<Integer>(trysolution);
NumSolns++;
NumSolns++;
return;
}
chosenCol = ChooseMinCol();
Expand Down