Skip to content

Commit 2c8bb0c

Browse files
committed
Add reconnectThreads functionality to ThreadedSocketInitiator.
- see #254 / #255 for original issue - improved error message in AbstractSocketAcceptor/Initiator
1 parent 655b3e4 commit 2c8bb0c

File tree

3 files changed

+11
-3
lines changed

3 files changed

+11
-3
lines changed

quickfixj-core/src/main/java/quickfix/ThreadedSocketInitiator.java

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public class ThreadedSocketInitiator extends AbstractSocketInitiator {
3131

3232
private ThreadedSocketInitiator(Builder builder) throws ConfigError {
3333
super(builder.application, builder.messageStoreFactory, builder.settings,
34-
builder.logFactory, builder.messageFactory);
34+
builder.logFactory, builder.messageFactory, builder.numReconnectThreads);
3535

3636
if (builder.queueCapacity >= 0) {
3737
eventHandlingStrategy
@@ -47,10 +47,18 @@ public static Builder newBuilder() {
4747
}
4848

4949
public static final class Builder extends AbstractSessionConnectorBuilder<Builder, ThreadedSocketInitiator> {
50+
51+
int numReconnectThreads = 3;
52+
5053
private Builder() {
5154
super(Builder.class);
5255
}
5356

57+
public Builder withReconnectThreads(int numReconnectThreads) throws ConfigError {
58+
this.numReconnectThreads = numReconnectThreads;
59+
return this;
60+
}
61+
5462
@Override
5563
protected ThreadedSocketInitiator doBuild() throws ConfigError {
5664
return new ThreadedSocketInitiator(this);

quickfixj-core/src/main/java/quickfix/mina/acceptor/AbstractSocketAcceptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ private void createSessions(SessionSettings settings) throws ConfigError, FieldC
238238
}
239239
} catch (Throwable t) {
240240
if (continueInitOnError) {
241-
log.error("error during session initialization, continuing...", t);
241+
log.error("error during session initialization for {}, continuing...", sessionID, t);
242242
} else {
243243
throw t instanceof ConfigError ? (ConfigError) t : new ConfigError(
244244
"error during session initialization", t);

quickfixj-core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ private void createSessions() throws ConfigError, FieldConvertError {
216216
}
217217
} catch (final Throwable e) {
218218
if (continueInitOnError) {
219-
log.error("error during session initialization, continuing...", e);
219+
log.error("error during session initialization for {}, continuing...", sessionID, e);
220220
} else {
221221
throw e instanceof ConfigError ? (ConfigError) e : new ConfigError(
222222
"error during session initialization", e);

0 commit comments

Comments
 (0)