Enhanced get_new_version (depends on #35) #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coud you/we look into this with some prio? As of now, the current code gives fatal errors when WP_Error is indeed triggered. Regardless of why there is a WP_Error, this really breaks the code badly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for the version is now just an call to empty() as that should do?
It then assumes 'null' as its default value and tries to get a new version. Which should always work, but if it does not it returns this 'null'
Maybe for better working the fallback should return sooner or the orginal transient should be returned or the 'null' could be converted to ''
Depends on #35. Or we wait for the previous commit.