From 8cbbf6bea945e12ba4f8fdd73a8cb7f6e27cedd7 Mon Sep 17 00:00:00 2001 From: MrZaphod Date: Wed, 13 Dec 2017 12:03:51 +0800 Subject: [PATCH 1/2] Update NsdHelper.java Attempt to fix a strict mode warning. --- library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java b/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java index db6399d..e9d668c 100644 --- a/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java +++ b/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java @@ -274,6 +274,10 @@ int findAvaiablePort() { logError("Couldn't assign port to your service.", 0, "java.net.ServerSocket"); e.printStackTrace(); return 0; + } finally { + if (socket != null) { + socket.close(); + } } } From bb2ad9b43d1624c84ad1d29bd4f260fd83779e60 Mon Sep 17 00:00:00 2001 From: MrZaphod Date: Wed, 13 Dec 2017 12:12:49 +0800 Subject: [PATCH 2/2] Update NsdHelper.java Fix silly mistake - I'm still learning how to do this effectivey. --- .../src/main/java/com/rafakob/nsdhelper/NsdHelper.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java b/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java index e9d668c..e12df79 100644 --- a/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java +++ b/library/src/main/java/com/rafakob/nsdhelper/NsdHelper.java @@ -269,15 +269,13 @@ int findAvaiablePort() { ServerSocket socket; try { socket = new ServerSocket(0); - return socket.getLocalPort(); + int socketNumber = socket.getLocalPort(); + socket.close(); + return socketNumber; } catch (IOException e) { logError("Couldn't assign port to your service.", 0, "java.net.ServerSocket"); e.printStackTrace(); return 0; - } finally { - if (socket != null) { - socket.close(); - } } }