File tree Expand file tree Collapse file tree 1 file changed +5
-4
lines changed Expand file tree Collapse file tree 1 file changed +5
-4
lines changed Original file line number Diff line number Diff line change @@ -312,7 +312,7 @@ def make_Fetch_Possible_And_Deterministic(o)
312312
313313
314314
315- if ( any_groupings? ( o ) || has_join_sources ?( o ) ) && ( projection = projection_to_order_by_for_fetch ( o ) )
315+ if ( any_groupings? ( o ) || xxx_has_join_sources ?( o ) ) && ( projection = projection_to_order_by_for_fetch ( o ) )
316316 o . orders = [ projection . asc ]
317317 else
318318 pk = primary_Key_From_Table ( table_From_Statement ( o ) )
@@ -325,16 +325,17 @@ def any_groupings?(o)
325325 end
326326
327327 # TODO: Need this for "in the subquery the first projection is used for ordering if none provided" test.
328- def has_join_sources? ( o )
328+ # TODO: rename
329+ def xxx_has_join_sources? ( o )
329330 # binding.pry if $DEBUG
330331
331332
332333 return false unless o . is_a? ( Arel ::Nodes ::SelectStatement )
333334
334335 # false
335336 o . cores . any? { |core | core . source . is_a? ( Arel ::Nodes ::JoinSource ) }
336- rescue => e
337- binding . pry
337+ # rescue => e
338+ # binding.pry
338339 end
339340
340341 # Find the first projection or part of projection that can be used for ordering. Cannot use
You can’t perform that action at this time.
0 commit comments