Cleanup

Author: aidanharan

lib/active_record/connection_adapters/sqlserver/schema_statements.rb

@@ -631,13 +631,6 @@ def column_type(ci:)
         end
 
         def column_definitions_sql(database, identifier)
-          # puts "column_definitions_sql: identifier=#{identifier}"
-          # puts "column_definitions_sql: database=#{database}"
-
-
-
-
-
           schema_name = "schema_name()"
 
           if prepared_statements
@@ -730,7 +723,7 @@ def remove_check_constraints(table_name, column_name)
         end
 
         def remove_default_constraint(table_name, column_name)
-          # If their are foreign keys in this table, we could still get back a 2D array, so flatten just in case.
+          # If there are foreign keys in this table, we could still get back a 2D array, so flatten just in case.
           execute_procedure(:sp_helpconstraint, table_name, "nomsg").flatten.select do |row|
             row["constraint_type"] == "DEFAULT on column #{column_name}"
           end.each do |row|

test/cases/temporary_table_test_sqlserver.rb

@@ -3,48 +3,17 @@
 require "cases/helper_sqlserver"
 
 class TemporaryTableSQLServer < ActiveRecord::TestCase
-  # setup do
-  #   @connection = ActiveRecord::Base.lease_connection
-  #   @connection.create_table(:barcodes, primary_key: "code", id: :uuid, force: true)
-  # end
-  #
-  # # teardown do
-  # #   @connection.drop_table(:barcodes, if_exists: true)
-  # # end
-  #
   def test_insert_into_temporary_table
-    ActiveSupport::Notifications.subscribe('sql.active_record') do |_name, _start, _finish, _id, payload|
-      puts payload[:sql]
-    end
-
-
     ActiveRecord::Base.with_connection do |conn|
-      temp_table = "#temp_users"
-      # connection.exec_query("IF OBJECT_ID('tempdb..#{temp_table}') IS NOT NULL DROP TABLE #{temp_table}")
-
-      puts "Creating table"
-      conn.exec_query("CREATE TABLE #{temp_table} (id INT IDENTITY(1,1), name NVARCHAR(100))")
-
-      puts "Selecting table"
-      result = conn.exec_query("SELECT * FROM #{temp_table}")
-      puts "Result: #{result.to_a}"
-
-      puts "Inserting into table"
-
-      # ❌ This raises "Table doesn’t exist" error
-      conn.exec_query("INSERT INTO #{temp_table} (name) VALUES ('John')")
-
-
+      conn.exec_query("CREATE TABLE #temp_users (id INT IDENTITY(1,1), name NVARCHAR(100))")
 
-      # ✅ Workaround: Only runs if the table still exists in this session
-      # conn.exec_query("IF OBJECT_ID('tempdb..#{temp_table}') IS NOT NULL INSERT INTO #{temp_table} (name) VALUES ('John')")
+      result = conn.exec_query("SELECT * FROM #temp_users")
+      assert_equal 0, result.count
 
-      # ✅ Workaround: raw_connection works without issue
-      # conn.raw_connection.execute("IF OBJECT_ID('tempdb..#{temp_table}') IS NOT NULL INSERT INTO #{temp_table} (name) VALUES ('John')")
+      conn.exec_query("INSERT INTO #temp_users (name) VALUES ('John'), ('Doe')")
 
-      puts "Selecting table again"
-      result = conn.exec_query("SELECT * FROM #{temp_table}")
-      puts "Result: #{result.to_a}"
+      result = conn.exec_query("SELECT * FROM #temp_users")
+      assert_equal 2, result.count
     end
   end
 end