Fix mismatched foreign key errors (#1215)

Author: aidanharan

CHANGELOG.md

@@ -9,4 +9,8 @@
 - [#1153](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1153) Only support Ruby v3.1+
 - [#1196](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1196) Use default inspect for database adapter
 
+#### Fixed
+
+- [#1215](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/1215) Fix mismatched foreign key errors
+
 Please check [7-1-stable](https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/blob/7-1-stable/CHANGELOG.md) for previous changes.

lib/active_record/connection_adapters/sqlserver_adapter.rb

@@ -431,36 +431,28 @@ def type_map
         TYPE_MAP
       end
 
-      def translate_exception(e, message:, sql:, binds:)
+      def translate_exception(exception, message:, sql:, binds:)
         case message
         when /(SQL Server client is not connected)|(failed to execute statement)/i
-          ConnectionNotEstablished.new(message)
+          ConnectionNotEstablished.new(message, connection_pool: @pool)
         when /(cannot insert duplicate key .* with unique index) | (violation of (unique|primary) key constraint)/i
-          RecordNotUnique.new(message, sql: sql, binds: binds)
+          RecordNotUnique.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /(conflicted with the foreign key constraint) | (The DELETE statement conflicted with the REFERENCE constraint)/i
-          InvalidForeignKey.new(message, sql: sql, binds: binds)
+          InvalidForeignKey.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /has been chosen as the deadlock victim/i
-          DeadlockVictim.new(message, sql: sql, binds: binds)
+          DeadlockVictim.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /database .* does not exist/i
-          NoDatabaseError.new(message)
+          NoDatabaseError.new(message, connection_pool: @pool)
         when /data would be truncated/
-          ValueTooLong.new(message, sql: sql, binds: binds)
+          ValueTooLong.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /connection timed out/
-          StatementTimeout.new(message, sql: sql, binds: binds)
+          StatementTimeout.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /Column '(.*)' is not the same data type as referencing column '(.*)' in foreign key/
-          pk_id, fk_id = SQLServer::Utils.extract_identifiers($1), SQLServer::Utils.extract_identifiers($2)
-          MismatchedForeignKey.new(
-            self,
-            message: message,
-            table: fk_id.schema,
-            foreign_key: fk_id.object,
-            target_table: pk_id.schema,
-            primary_key: pk_id.object
-          )
+          MismatchedForeignKey.new(message: message, connection_pool: @pool)
         when /Cannot insert the value NULL into column.*does not allow nulls/
-          NotNullViolation.new(message, sql: sql, binds: binds)
+          NotNullViolation.new(message, sql: sql, binds: binds, connection_pool: @pool)
         when /Arithmetic overflow error/
-          RangeError.new(message, sql: sql, binds: binds)
+          RangeError.new(message, sql: sql, binds: binds, connection_pool: @pool)
         else
           super
         end

test/cases/adapter_test_sqlserver.rb

@@ -580,4 +580,26 @@ def test_doesnt_error_when_a_select_query_is_called_while_preventing_writes
       end
     end
   end
+
+  describe "mismatched foreign keys error" do
+    def setup
+      @conn = ActiveRecord::Base.lease_connection
+    end
+
+    it 'raises an error when the foreign key is mismatched' do
+     error = assert_raises(ActiveRecord::MismatchedForeignKey) do
+        @conn.add_reference :engines, :old_car
+        @conn.add_foreign_key :engines, :old_cars
+      end
+
+      assert_match(
+        %r/Column 'old_cars\.id' is not the same data type as referencing column 'engines\.old_car_id' in foreign key '.*'/,
+        error.message
+      )
+      assert_not_nil error.cause
+      assert_equal @conn.pool, error.connection_pool
+    ensure
+      @conn.execute("ALTER TABLE engines DROP COLUMN old_car_id") rescue nil
+    end
+  end
 end