[BUG] Tune button is not working

[Dfinitski]

The Tune button pressing is not causing appear bit 1 in byte 58 in General packet sending to TRX (New protocol).

Recomendation:
replace network.c line 680 to
packetbuf[58] = ((!prn->tx[0].pa) & 0x01) | (ApolloATU==0 ? 0x00 : 0x02);

Comment out the ATU control condition in console.cs
line 39014
//if (apollopresent && apollo_tuner_enabled)

line 39052
//if (apollopresent)

[Dfinitski]

It does not make sense to limit Tune button by Apollo presence, it is just one bit wich will be interpreted by hardware as it should. Also The Tuner button will be helpful for immediat RF CW producing for numerous reason.

[ramdor]

I need to discuss with a few preople why this has been ommited from the Thetis protocol 2 implemntation for so long. The bit is documented as for the Apollo tuner only in the current protocol 2 documentation, so bypassing the apollo restrictions might not be the way to go if it impacts other radios/hardware. There should probably be a discusson on whether the bit is now to be used as a general 'is in tune' bit or to remain limited for apollo.

@n1gp @laurencebarker @NR0V

[Dfinitski]

Apollo is not in use for a long time. This is the atavism, as all the openhpsdr hardware in overall. The current existing hardware will use this bit if it's needed or don't use it, if not. Apollo does not exist as real device now.

[ramdor]

It is not as simple as just changing the whole of Thetis, as there are other things to consider doing this, and until the full information is obtained then I will not be doing anything. Until I get the go-ahead to change/remove apollo from the code then it will have to stay as it is. There are tabs/controls related to apollo/atu, there are manual references in the Protocol documentation etc.etc.

I can add the bit back into the general packet from Thetis no problem, but it will remain gated as it is now behind apollo being selected and the atu present. If you need it for another radio, then propose a change that will include that radio in the model drop drown that enables apollo/atu.

[Dfinitski]

No, that is too complicated, to add a device just for 1 bit using.
I would like to use Anan 100D profile with the ability to set Apollo check box and get my tune button and 58/1 bit strictly according to the protocol description.

[ramdor]

well you are out of luck in this master repo atm, until I get the go-ahead to strip the apollo gating, or to make Apollo availble to all radio models. You wIll have to wait until feedback received from Laurence and Rick. Warren has no recollection of the the use of the tune bit atm.

[laurencebarker]

Hi Richie

As far as I know there are Apollo boards in use, with Hermes digital boards. I've seen one. My understanding is that the ATU either didn't work well or at all. The person who would have known is of course Kjell, and sadly he isn't with us any more. 

The bit as documented is an Apollo bit and not a more general one. The documentation doesn't say anything about its purpose though. 

I'm not sure what the request is here: but as an observation an ATU needs to know two things. "Is the ATU enabled for use" (which I think was the intent of that bit); and "is the Tune button pressed telling me to tune now" (which I think isn't the function of that bit). An ATU can find those things out by CAT message too. 

If there was to be any change, there should be better documentation about the purpose of the bits. If there is a need for the data for other purposes, I would prefer to use a different bit whose purpose can be properly documented. A bit that signals "TUNE button is pressed" would probably be useful.

Rick and I updated the protocol documentation, so up to date source files for the protocol are available if we want to make a change.

[ramdor]

Hi Laurence, cheers for the info. Yes whilst Thetis is not actively setting the bit at all it looks like it has not resulted in someone asking why their Apollo tuner isnt working, so is probably not of much importance anymore. That said, I do agree that we should really keep things as they are, and as you suggest use another free bit. We should not just blindy cast asside existing defined bit(s) in the protcol/documentation.

Currently pressing the tune button in thetis calls...

NetworkIO.EnableApolloAutoTune(chkTUN.Checked ? 1 : 0);

So it is implying that this bit is setting the ATU tune state on/off, as opposed to 'tuner is there, tuner is not there'. This fucntion is only called if apollo present and apollo tuner enabled, in Thetis setup ui.

Protocol 1 does make use of all of this info, but P2 does not currently send this bit.

At the moment, the radio model Dfinitski wants to use does not provide the options to change Apollo settings, they are hidden with the 100d.

Options

1. remove radio limitiations and allow Apollo settings to be changed with any radio
2. add another bit, 'IsTuning' or some such, as you suggest, and update documents
3. Dfinitski could add another radio model, based on the 100d, but with the apollo stuff available/preset

In all above cases, the P2 issue to send the apollo bit should also be fixed.

Cheers. R.

[Dfinitski]

Richie , please tell me how is the hardware sends info to Thetis about Apollo presence?

[ramdor]

not sure it does, the availabilty of UI options are enabled/disabled/hideen in setup.cs comboRadioModel_SelectedIndexChanged. That said I havent looked to see if the protocol returns any such info.

[Dfinitski]

thats right, Thetis never know about Appollo presence, that is an user choice only.