From da0c13bfa2a94539bc1bc34a224f67bc67a22060 Mon Sep 17 00:00:00 2001
From: Eivind Gamst <eivindgamst@proton.me>
Date: Mon, 27 Apr 2026 14:00:14 +0200
Subject: [PATCH] fix: benchmarks

---
 benches/bench_compose.rs |  6 +++---
 benches/bench_key.rs     | 23 ++++++++++++++++++++---
 benches/bench_setup.rs   |  6 +++---
 3 files changed, 26 insertions(+), 9 deletions(-)

diff --git a/benches/bench_compose.rs b/benches/bench_compose.rs
index 76505079..913f1281 100644
--- a/benches/bench_compose.rs
+++ b/benches/bench_compose.rs
@@ -8,9 +8,9 @@ use wkb::testing::composer_feed;
 
 fn cfg() -> Criterion {
     Criterion::default()
-        .warm_up_time(Duration::from_millis(50))
-        .measurement_time(Duration::from_millis(200))
-        .sample_size(10)
+        .warm_up_time(Duration::from_millis(200))
+        .measurement_time(Duration::from_secs(1))
+        .sample_size(50)
 }
 
 fn bench_compose_feed(c: &mut Criterion) {
diff --git a/benches/bench_key.rs b/benches/bench_key.rs
index 8e04a915..926cdbf2 100644
--- a/benches/bench_key.rs
+++ b/benches/bench_key.rs
@@ -10,9 +10,9 @@ use wkb::testing::{KeyDirection, WKBTestExt};
 
 fn cfg() -> Criterion {
     Criterion::default()
-        .warm_up_time(Duration::from_millis(50))
-        .measurement_time(Duration::from_millis(200))
-        .sample_size(10)
+        .warm_up_time(Duration::from_millis(200))
+        .measurement_time(Duration::from_secs(1))
+        .sample_size(50)
 }
 
 // ── Setup helpers ──────────────────────────────────────────────────────
@@ -314,6 +314,23 @@ fn bench_key_get_sym(c: &mut Criterion) {
                 }
             );
 
+            bench_xkb!(
+                group,
+                bid,
+                locale,
+                variant,
+                case,
+                |st: &mut xkbcommon::xkb::State,
+                 kc: xkbcommon::xkb::Keycode,
+                 down: bool,
+                 dir: xkbcommon::xkb::KeyDirection| {
+                    st.update_key(kc, dir);
+                    if down {
+                        black_box(st.key_get_one_sym(black_box(kc)));
+                    }
+                }
+            );
+
             bench_dl!(
                 group,
                 bid,
diff --git a/benches/bench_setup.rs b/benches/bench_setup.rs
index 20869aa1..3ac432c6 100644
--- a/benches/bench_setup.rs
+++ b/benches/bench_setup.rs
@@ -8,9 +8,9 @@ use std::time::Duration;
 
 fn cfg() -> Criterion {
     Criterion::default()
-        .warm_up_time(Duration::from_millis(50))
-        .measurement_time(Duration::from_millis(300))
-        .sample_size(10)
+        .warm_up_time(Duration::from_millis(200))
+        .measurement_time(Duration::from_secs(1))
+        .sample_size(20)
 }
 
 fn bench_setup_no_compose(c: &mut Criterion) {