Improve version detection and replace use of fail with raise

Author: rastating

lib/wpxf/wordpress/fingerprint.rb

@@ -197,12 +197,23 @@ def content_directory_name(type)
     when :theme
       return 'themes'
     else
-      fail("Unknown readme type #{type}")
+      raise("Unknown readme type #{type}")
     end
   end
 
+  def extract_highest_version(body, pattern)
+    version = nil
+
+    body.scan(pattern) do |match|
+      match_version = Gem::Version.new(match[0])
+      version = match_version if version.nil? || match_version > version
+    end
+
+    version
+  end
+
   def extract_and_check_version(body, pattern, fixed = nil, introduced = nil)
-    version = body[pattern, 1]
+    version = extract_highest_version(body, pattern)
     return :unknown if version.nil?
 
     version = Gem::Version.new(version)
@@ -224,7 +235,7 @@ def extension_version_pattern(type)
       # Version: 1.5.2
       return /(?:Version):\s*([0-9a-z.-]+)/i
     else
-      fail("Unknown file type #{type}")
+      raise("Unknown file type #{type}")
     end
   end
 end