[dashboard] upgrade requests to 2.32.5 in tests #59056
Conversation
it is uv runtime env, which installs the requests library for real. it was using requests 2.3.0, which is too old and does not run on python 3.10+ Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly upgrades the requests library version in a test environment to fix compatibility issues with Python 3.10+. The change is straightforward and well-justified. I have one minor suggestion regarding maintainability, but overall the change is good.
| node_id = ray_start_with_dashboard["node_id"] | ||
|
|
||
| @ray.remote(runtime_env={"uv": {"packages": ["requests==2.3.0"]}}) | ||
| @ray.remote(runtime_env={"uv": {"packages": ["requests==2.32.5"]}}) |
There was a problem hiding this comment.
To improve maintainability and avoid using a magic string for the version number, consider defining '2.32.5' as a constant at the top of the file. For example: _REQUESTS_VERSION_FOR_TEST = '2.32.5'. You could then use an f-string here: f'requests=={_REQUESTS_VERSION_FOR_TEST}'. This would make the version number easier to find and update if it's ever used in more than one place in this test file.
it is uv runtime env, which installs the requests library for real. it was using requests 2.3.0, which is too old and does not run on python 3.10+