Skip to content

remote S3 support #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
carrolp wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

remote S3 support #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
836a922
use AWS sign v4
carrolp Feb 2, 2023
167886f
Merge branch 'master' into s3-20230124
carrolp Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/RemoteResourceS3Controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ module.exports = class RemoteResourceS3Controller extends BaseDownloadController
let { accessKeyId, secretAccessKey } = await this._fetchHmacSecrets(hmac);
objectPath.set(options, 'aws.key', accessKeyId);
objectPath.set(options, 'aws.secret', secretAccessKey);
objectPath.set(options, 'aws.sign_version', 4);
} else if (iam) {
let bearerToken = await this._fetchS3Token(iam);
objectPath.set(options, 'headers.Authorization', `bearer ${bearerToken}`);
Expand Down