Skip to content

PR : gh #231: Refactor makefile to include changes in ut-control #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kanjoe24 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

PR : gh #231: Refactor makefile to include changes in ut-control #232

kanjoe24 wants to merge 1 commit into from

Conversation

@kanjoe24
Copy link
Contributor

@kanjoe24 kanjoe24 commented Dec 22, 2025

Refactoring makefile to include changes in ut-control

@kanjoe24 kanjoe24 requested a review from a team as a code owner December 22, 2025 13:41
Copilot AI review requested due to automatic review settings December 22, 2025 13:41
kanjoe24
kanjoe24 commented Dec 22, 2025
View reviewed changes
build.sh
# Change this to upgrade your ut-control Major versions. Non ABI Changes 1.x.x are supported, between major revisions

UT_CONTROL_PROJECT_VERSION="2.0.0" # Fixed version
UT_CONTROL_PROJECT_VERSION="feature/gh109_Makefile_Update_avoid_hardcodedpaths" # Fixed version
Copy link
Contributor Author

@kanjoe24 kanjoe24 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this to latest ut-control before merging.

Copy link
Contributor

@Ulrond Ulrond Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need a feature branch for that, unless you are doing changes for ut-core, just upgrade it as part of your release branch...

@kanjoe24 kanjoe24 self-assigned this Dec 22, 2025
@kanjoe24 kanjoe24 linked an issue Dec 22, 2025 that may be closed by this pull request
Task:Integrate ut-control gh109 to ut-core and bring in corresponding changes #231
Open
Copilot AI reviewed Dec 22, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the build configuration to support passing compiler information to the ut-control submodule. The changes aim to avoid hardcoded paths by explicitly passing the compiler to ut-control during its build process.

Key Changes:

  • Modified UT_CONTROL_PROJECT_VERSION to use a feature branch instead of a fixed version tag
  • Introduced UT_CONTROL_COMPILER variable to explicitly pass compiler information to ut-control
  • Updated the ut-control build invocation to use the new compiler variable

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
build.sh Changed ut-control version from "2.0.0" to feature branch "feature/gh109_Makefile_Update_avoid_hardcodedpaths"
Makefile Added UT_CONTROL_COMPILER variable and modified ut-control build command to pass compiler explicitly

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kanjoe24
Copy link
Contributor Author

kanjoe24 commented Dec 22, 2025

release script results:

./release-test-script-platform.sh -t feature/gh231-changes-for-ut-control-gh109
UT_CORE_BRANCH_NAME = feature/gh231-changes-for-ut-control-gh109
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==========================================================
RESULTS for ubuntu 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-ubuntu
ut/bin/hal_test_RCECHal exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-VM-SYNC_linux
ut/bin/hal_test_RCECHal exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
ut/ut-core/framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-dunfell_arm
ut/bin/hal_test_RCECHal exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-dunfell_linux
ut/bin/hal_test_RCECHal exists. PASS
CURL static lib does not exist. PASS
Openssl static lib does not exist. PASS 
CMake host binary exists. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-kirkstone_arm
ut/bin/hal_test_RCECHal exists. PASS
ut/ut-core/framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
ut/ut-core/framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
            . PASS
/home/jpn323/workspace/ut-core-dec-2025/scripts/rdk-halif-hdmi_cec-kirkstone_linux
ut/bin/hal_test_RCECHal exists. PASS
ut/ut-core/framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
==========================================================
jpn323@janus ~/workspace/ut-core-dec-2025/scripts (feature/gh231-changes-for-ut-control-gh109)$ 
jpn323@janus ~/workspace/ut-core-dec-2025/scripts (feature/gh231-changes-for-ut-control-gh109)$ ./release-test-script-ut-core.sh -t feature/gh231-changes-for-ut-control-gh109
UT_CORE_BRANCH_NAME = feature/gh231-changes-for-ut-control-gh109
UT_CONTROL_BRANCH_NAME = 
UT_CONTROL_BRANCH_NAME is empty
==================== RESULTS FOR C VARIANT ====================
==========================================================
RESULTS for ubuntu 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
CURL static lib does not exist. PASS
Openssl static lib does not exist. PASS 
CMake host binary exists. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
hal_test does not exist. PASS 
tests/build/bin/ut-test exists. PASS
==========================================================
==================== RESULTS FOR CPP VARIANT ====================
==========================================================
RESULTS for ubuntu 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for VM-SYNC 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/linux/openssl/lib/libssl.a exists. PASS 
framework/ut-control/host-tools/CMake-3.30.0/build/bin/cmake exists. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for dunfell_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
CURL static lib does not exist. PASS
Openssl static lib does not exist. PASS 
CMake host binary exists. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_arm 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/arm/curl/lib/libcurl.a exists. PASS
framework/ut-control/build/arm/openssl/lib/libssl.a exists. PASS 
CMake host binary does not exist. PASS 
build/arm/cpp_libs/lib/libgtest.a exists. PASS
build/arm/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================
==========================================================
RESULTS for kirkstone_linux 
On the branch feature/gh231-changes-for-ut-control-gh109
        . PASS
framework/ut-control/build/linux/curl/lib/libcurl.a exists. PASS
Openssl static lib does not exist. PASS 
CMake host binary does not exist. PASS 
build/linux/cpp_libs/lib/libgtest.a exists. PASS
build/linux/cpp_libs/lib/libgtest_main.a exists. PASS
build/bin/hal_test exists. PASS
tests/build/bin/ut-test exists. PASS
==========================================================

@github-project-automation github-project-automation bot moved this from Todo to Approved For Merge in UT-Core Roadmap Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Ulrond Ulrond Ulrond approved these changes

Assignees

@kanjoe24 kanjoe24

Labels

None yet

Projects

UT-Core Roadmap
Status: Approved For Merge

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Task:Integrate ut-control gh109 to ut-core and bring in corresponding changes

3 participants

@kanjoe24 @Ulrond