Skip to content

Commit 6bedd52

Browse files
aojunhao123小豪
aojunhao123
and
小豪
authored
fix: add aria-hidden attribute to visually hidden input element (#279)
Co-authored-by: 小豪 <aojunhao@cai-inc.com>
1 parent 02aa14a commit 6bedd52

File tree

2 files changed

+41
-0
lines changed

2 files changed

+41
-0
lines changed

‎src/index.tsx‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ const InternalSegmentedOption: React.FC<{
107107
>
108108
<input
109109
className={`${prefixCls}-item-input`}
110+
aria-hidden="true"
110111
type="radio"
111112
disabled={disabled}
112113
checked={checked}

‎tests/__snapshots__/index.test.tsx.snap‎

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ exports[`rc-segmented render label with ReactNode 1`] = `
2525
class="rc-segmented-item rc-segmented-item-selected"
2626
>
2727
<input
28+
aria-hidden="true"
2829
checked=""
2930
class="rc-segmented-item-input"
3031
type="radio"
@@ -42,6 +43,7 @@ exports[`rc-segmented render label with ReactNode 1`] = `
4243
class="rc-segmented-item"
4344
>
4445
<input
46+
aria-hidden="true"
4547
class="rc-segmented-item-input"
4648
type="radio"
4749
/>
@@ -61,6 +63,7 @@ exports[`rc-segmented render label with ReactNode 1`] = `
6163
class="rc-segmented-item"
6264
>
6365
<input
66+
aria-hidden="true"
6467
class="rc-segmented-item-input"
6568
type="radio"
6669
/>
@@ -91,6 +94,7 @@ exports[`rc-segmented render segmented ok 1`] = `
9194
class="rc-segmented-item rc-segmented-item-selected"
9295
>
9396
<input
97+
aria-hidden="true"
9498
checked=""
9599
class="rc-segmented-item-input"
96100
type="radio"
@@ -108,6 +112,7 @@ exports[`rc-segmented render segmented ok 1`] = `
108112
class="rc-segmented-item"
109113
>
110114
<input
115+
aria-hidden="true"
111116
class="rc-segmented-item-input"
112117
type="radio"
113118
/>
@@ -124,6 +129,7 @@ exports[`rc-segmented render segmented ok 1`] = `
124129
class="rc-segmented-item"
125130
>
126131
<input
132+
aria-hidden="true"
127133
class="rc-segmented-item-input"
128134
type="radio"
129135
/>
@@ -153,6 +159,7 @@ exports[`rc-segmented render segmented with CSSMotion basic 1`] = `
153159
class="rc-segmented-item rc-segmented-item-selected"
154160
>
155161
<input
162+
aria-hidden="true"
156163
checked=""
157164
class="rc-segmented-item-input"
158165
type="radio"
@@ -170,6 +177,7 @@ exports[`rc-segmented render segmented with CSSMotion basic 1`] = `
170177
class="rc-segmented-item"
171178
>
172179
<input
180+
aria-hidden="true"
173181
class="rc-segmented-item-input"
174182
type="radio"
175183
/>
@@ -186,6 +194,7 @@ exports[`rc-segmented render segmented with CSSMotion basic 1`] = `
186194
class="rc-segmented-item"
187195
>
188196
<input
197+
aria-hidden="true"
189198
class="rc-segmented-item-input"
190199
type="radio"
191200
/>
@@ -215,6 +224,7 @@ exports[`rc-segmented render segmented with options 1`] = `
215224
class="rc-segmented-item rc-segmented-item-selected"
216225
>
217226
<input
227+
aria-hidden="true"
218228
checked=""
219229
class="rc-segmented-item-input"
220230
type="radio"
@@ -232,6 +242,7 @@ exports[`rc-segmented render segmented with options 1`] = `
232242
class="rc-segmented-item"
233243
>
234244
<input
245+
aria-hidden="true"
235246
class="rc-segmented-item-input"
236247
type="radio"
237248
/>
@@ -248,6 +259,7 @@ exports[`rc-segmented render segmented with options 1`] = `
248259
class="rc-segmented-item"
249260
>
250261
<input
262+
aria-hidden="true"
251263
class="rc-segmented-item-input"
252264
type="radio"
253265
/>
@@ -277,6 +289,7 @@ exports[`rc-segmented render segmented with options null/undefined 1`] = `
277289
class="rc-segmented-item rc-segmented-item-selected rc-segmented-item-disabled"
278290
>
279291
<input
292+
aria-hidden="true"
280293
checked=""
281294
class="rc-segmented-item-input"
282295
disabled=""
@@ -292,6 +305,7 @@ exports[`rc-segmented render segmented with options null/undefined 1`] = `
292305
class="rc-segmented-item rc-segmented-item-disabled"
293306
>
294307
<input
308+
aria-hidden="true"
295309
class="rc-segmented-item-input"
296310
disabled=""
297311
type="radio"
@@ -306,6 +320,7 @@ exports[`rc-segmented render segmented with options null/undefined 1`] = `
306320
class="rc-segmented-item rc-segmented-item-disabled"
307321
>
308322
<input
323+
aria-hidden="true"
309324
class="rc-segmented-item-input"
310325
disabled=""
311326
type="radio"
@@ -334,6 +349,7 @@ exports[`rc-segmented render segmented with options: 1 1`] = `
334349
class="rc-segmented-item rc-segmented-item-selected"
335350
>
336351
<input
352+
aria-hidden="true"
337353
checked=""
338354
class="rc-segmented-item-input"
339355
type="radio"
@@ -351,6 +367,7 @@ exports[`rc-segmented render segmented with options: 1 1`] = `
351367
class="rc-segmented-item"
352368
>
353369
<input
370+
aria-hidden="true"
354371
class="rc-segmented-item-input"
355372
type="radio"
356373
/>
@@ -367,6 +384,7 @@ exports[`rc-segmented render segmented with options: 1 1`] = `
367384
class="rc-segmented-item"
368385
>
369386
<input
387+
aria-hidden="true"
370388
class="rc-segmented-item-input"
371389
type="radio"
372390
/>
@@ -383,6 +401,7 @@ exports[`rc-segmented render segmented with options: 1 1`] = `
383401
class="rc-segmented-item"
384402
>
385403
<input
404+
aria-hidden="true"
386405
class="rc-segmented-item-input"
387406
type="radio"
388407
/>
@@ -399,6 +418,7 @@ exports[`rc-segmented render segmented with options: 1 1`] = `
399418
class="rc-segmented-item"
400419
>
401420
<input
421+
aria-hidden="true"
402422
class="rc-segmented-item-input"
403423
type="radio"
404424
/>
@@ -428,6 +448,7 @@ exports[`rc-segmented render segmented with options: 2 1`] = `
428448
class="rc-segmented-item rc-segmented-item-selected"
429449
>
430450
<input
451+
aria-hidden="true"
431452
checked=""
432453
class="rc-segmented-item-input"
433454
type="radio"
@@ -445,6 +466,7 @@ exports[`rc-segmented render segmented with options: 2 1`] = `
445466
class="rc-segmented-item"
446467
>
447468
<input
469+
aria-hidden="true"
448470
class="rc-segmented-item-input"
449471
type="radio"
450472
/>
@@ -461,6 +483,7 @@ exports[`rc-segmented render segmented with options: 2 1`] = `
461483
class="rc-segmented-item"
462484
>
463485
<input
486+
aria-hidden="true"
464487
class="rc-segmented-item-input"
465488
type="radio"
466489
/>
@@ -490,6 +513,7 @@ exports[`rc-segmented render segmented with options: disabled 1`] = `
490513
class="rc-segmented-item rc-segmented-item-selected"
491514
>
492515
<input
516+
aria-hidden="true"
493517
checked=""
494518
class="rc-segmented-item-input"
495519
type="radio"
@@ -507,6 +531,7 @@ exports[`rc-segmented render segmented with options: disabled 1`] = `
507531
class="rc-segmented-item rc-segmented-item-disabled"
508532
>
509533
<input
534+
aria-hidden="true"
510535
class="rc-segmented-item-input"
511536
disabled=""
512537
type="radio"
@@ -524,6 +549,7 @@ exports[`rc-segmented render segmented with options: disabled 1`] = `
524549
class="rc-segmented-item"
525550
>
526551
<input
552+
aria-hidden="true"
527553
class="rc-segmented-item-input"
528554
type="radio"
529555
/>
@@ -553,6 +579,7 @@ exports[`rc-segmented render segmented with title 1`] = `
553579
class="rc-segmented-item rc-segmented-item-selected"
554580
>
555581
<input
582+
aria-hidden="true"
556583
checked=""
557584
class="rc-segmented-item-input"
558585
type="radio"
@@ -570,6 +597,7 @@ exports[`rc-segmented render segmented with title 1`] = `
570597
class="rc-segmented-item"
571598
>
572599
<input
600+
aria-hidden="true"
573601
class="rc-segmented-item-input"
574602
type="radio"
575603
/>
@@ -586,6 +614,7 @@ exports[`rc-segmented render segmented with title 1`] = `
586614
class="rc-segmented-item"
587615
>
588616
<input
617+
aria-hidden="true"
589618
class="rc-segmented-item-input"
590619
type="radio"
591620
/>
@@ -603,6 +632,7 @@ exports[`rc-segmented render segmented with title 1`] = `
603632
class="rc-segmented-item"
604633
>
605634
<input
635+
aria-hidden="true"
606636
class="rc-segmented-item-input"
607637
type="radio"
608638
/>
@@ -619,6 +649,7 @@ exports[`rc-segmented render segmented with title 1`] = `
619649
class="rc-segmented-item"
620650
>
621651
<input
652+
aria-hidden="true"
622653
class="rc-segmented-item-input"
623654
type="radio"
624655
/>
@@ -648,6 +679,7 @@ exports[`rc-segmented render segmented: disabled 1`] = `
648679
class="rc-segmented-item rc-segmented-item-selected rc-segmented-item-disabled"
649680
>
650681
<input
682+
aria-hidden="true"
651683
checked=""
652684
class="rc-segmented-item-input"
653685
disabled=""
@@ -666,6 +698,7 @@ exports[`rc-segmented render segmented: disabled 1`] = `
666698
class="rc-segmented-item rc-segmented-item-disabled"
667699
>
668700
<input
701+
aria-hidden="true"
669702
class="rc-segmented-item-input"
670703
disabled=""
671704
type="radio"
@@ -683,6 +716,7 @@ exports[`rc-segmented render segmented: disabled 1`] = `
683716
class="rc-segmented-item rc-segmented-item-disabled"
684717
>
685718
<input
719+
aria-hidden="true"
686720
class="rc-segmented-item-input"
687721
disabled=""
688722
type="radio"
@@ -713,6 +747,7 @@ exports[`rc-segmented should render vertical segmented 1`] = `
713747
class="rc-segmented-item rc-segmented-item-selected"
714748
>
715749
<input
750+
aria-hidden="true"
716751
checked=""
717752
class="rc-segmented-item-input"
718753
type="radio"
@@ -730,6 +765,7 @@ exports[`rc-segmented should render vertical segmented 1`] = `
730765
class="rc-segmented-item"
731766
>
732767
<input
768+
aria-hidden="true"
733769
class="rc-segmented-item-input"
734770
type="radio"
735771
/>
@@ -746,6 +782,7 @@ exports[`rc-segmented should render vertical segmented 1`] = `
746782
class="rc-segmented-item"
747783
>
748784
<input
785+
aria-hidden="true"
749786
class="rc-segmented-item-input"
750787
type="radio"
751788
/>
@@ -775,6 +812,7 @@ exports[`rc-segmented should render vertical segmented and handle thumb animatio
775812
class="rc-segmented-item rc-segmented-item-selected"
776813
>
777814
<input
815+
aria-hidden="true"
778816
checked=""
779817
class="rc-segmented-item-input"
780818
type="radio"
@@ -792,6 +830,7 @@ exports[`rc-segmented should render vertical segmented and handle thumb animatio
792830
class="rc-segmented-item"
793831
>
794832
<input
833+
aria-hidden="true"
795834
class="rc-segmented-item-input"
796835
type="radio"
797836
/>
@@ -808,6 +847,7 @@ exports[`rc-segmented should render vertical segmented and handle thumb animatio
808847
class="rc-segmented-item"
809848
>
810849
<input
850+
aria-hidden="true"
811851
class="rc-segmented-item-input"
812852
type="radio"
813853
/>

0 commit comments

Comments
 (0)