Skip to content

Commit 2c6e141

Browse files
committed
fix(slider): do not pass event to onChange handlers
1 parent f49a107 commit 2c6e141

File tree

3 files changed

+10
-17
lines changed

3 files changed

+10
-17
lines changed

src/Slider/Slider.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -343,8 +343,8 @@ describe('<Slider />', () => {
343343
);
344344

345345
expect(handleChange).toHaveBeenCalledTimes(2);
346-
expect(handleChange.mock.calls[0][1]).toBe(80);
347-
expect(handleChange.mock.calls[1][1]).toBe(78);
346+
expect(handleChange.mock.calls[0][0]).toBe(80);
347+
expect(handleChange.mock.calls[1][0]).toBe(78);
348348
});
349349
});
350350

src/Slider/Slider.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ export default {
4343
export function Default() {
4444
const [state, setState] = React.useState(0);
4545

46-
const onChange: SliderOnChangeHandler = (_, newValue) => setState(newValue);
46+
const onChange: SliderOnChangeHandler = newValue => setState(newValue);
4747

4848
return (
4949
<div className='row'>

src/Slider/Slider.tsx

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,7 @@ import { clamp, getSize, roundValueToStep } from '../common/utils';
2424
import { StyledScrollView } from '../ScrollView/ScrollView';
2525
import { CommonStyledProps } from '../types';
2626

27-
export type SliderOnChangeHandler = (
28-
event:
29-
| MouseEvent
30-
| React.KeyboardEvent<HTMLSpanElement>
31-
| React.MouseEvent<HTMLDivElement>
32-
| TouchEvent,
33-
value: number
34-
) => void;
27+
export type SliderOnChangeHandler = (value: number) => void;
3528

3629
type SliderProps = {
3730
defaultValue?: number;
@@ -419,8 +412,8 @@ const Slider = forwardRef<HTMLDivElement, SliderProps>(
419412
setValueState(newValue);
420413
setFocusVisible(true);
421414

422-
onChange?.(event, newValue);
423-
onChangeCommitted?.(event, newValue);
415+
onChange?.(newValue);
416+
onChangeCommitted?.(newValue);
424417
}
425418
);
426419

@@ -466,7 +459,7 @@ const Slider = forwardRef<HTMLDivElement, SliderProps>(
466459
setValueState(newValue);
467460
setFocusVisible(true);
468461

469-
onChange?.(event, newValue);
462+
onChange?.(newValue);
470463
}
471464
);
472465

@@ -480,7 +473,7 @@ const Slider = forwardRef<HTMLDivElement, SliderProps>(
480473

481474
const newValue = getNewValue(finger);
482475

483-
onChangeCommitted?.(event, newValue);
476+
onChangeCommitted?.(newValue);
484477

485478
touchId.current = undefined;
486479

@@ -505,7 +498,7 @@ const Slider = forwardRef<HTMLDivElement, SliderProps>(
505498
if (finger) {
506499
const newValue = getNewValue(finger);
507500
setValueState(newValue);
508-
onChange?.(event, newValue);
501+
onChange?.(newValue);
509502
}
510503

511504
const doc = ownerDocument(sliderRef.current);
@@ -530,7 +523,7 @@ const Slider = forwardRef<HTMLDivElement, SliderProps>(
530523
if (finger) {
531524
const newValue = getNewValue(finger);
532525
setValueState(newValue);
533-
onChange?.(event, newValue);
526+
onChange?.(newValue);
534527
}
535528

536529
const doc = ownerDocument(sliderRef.current);

0 commit comments

Comments
 (0)