Use context data instead of one off template tags (#12506)

We will be inspecting more than just existance of the GHA provider, it's
easier to just have a simple lookup list than tags for each
provider for this. The tag removed is not used anymore now, context data
is used instead.

- Required by ext-theme#648

Author: agjohnson

readthedocs/core/templatetags/readthedocs/socialaccounts.py

@@ -41,9 +41,3 @@ def has_github_app_account(account):
         provider=GitHubAppProvider.id,
         uid=account.uid,
     ).exists()
-
-
-@register.filter
-def user_has_github_app_account(user):
-    """Check if a user has a GitHub App account."""
-    return user.socialaccount_set.filter(provider=GitHubAppProvider.id).exists()

readthedocs/projects/views/private.py

@@ -461,6 +461,12 @@ def get_context_data(self, **kwargs):
         context["form_manual"] = ProjectManualForm(user=self.request.user)
         context["GITHUB_APP_NAME"] = settings.GITHUB_APP_NAME
 
+        # Provider list for simple lookup of connected services, used for
+        # conditional content
+        context["socialaccount_providers"] = self.request.user.socialaccount_set.values_list(
+            "provider", flat=True
+        )
+
         return context