From 4c8334d26a6ca3bed5bdbe56583cef557915aa4b Mon Sep 17 00:00:00 2001 From: NagyVikt Date: Wed, 22 Apr 2026 12:10:19 +0200 Subject: [PATCH] Keep merged cleanup evidence truthful The install-suite split branch already merged, but its change checklist still showed the cleanup section as incomplete. This patch records the actual PR, merge commit, and ref-prune evidence so the artifact matches the verified repo state. Constraint: Original worktree was already pruned, so the evidence update had to land from a tiny follow-up helper lane Rejected: Leave the cleanup boxes unchecked and rely only on chat handoff text | the change definition of done explicitly requires checked cleanup evidence Confidence: high Scope-risk: narrow Reversibility: clean Directive: When cleanup proof lands after merge, patch the change artifact instead of leaving stale unchecked completion boxes behind Tested: openspec validate agent-codex-install-suite-split-and-cli-surface-clea-2026-04-22-10-52 --type change --strict Tested: git worktree list; git branch -a; gh pr view agent/codex/install-suite-split-and-cli-surface-clea-2026-04-22-10-52 --repo recodeee/gitguardex --json number,state,url,headRefName,baseRefName,mergeCommit Not-tested: code/test suites unchanged by this tasks.md-only evidence patch --- .../tasks.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/openspec/changes/agent-codex-install-suite-split-and-cli-surface-clea-2026-04-22-10-52/tasks.md b/openspec/changes/agent-codex-install-suite-split-and-cli-surface-clea-2026-04-22-10-52/tasks.md index ed76244..a6b2767 100644 --- a/openspec/changes/agent-codex-install-suite-split-and-cli-surface-clea-2026-04-22-10-52/tasks.md +++ b/openspec/changes/agent-codex-install-suite-split-and-cli-surface-clea-2026-04-22-10-52/tasks.md @@ -47,6 +47,6 @@ This change is complete only when **all** of the following are true: ## 4. Cleanup (mandatory; run before claiming completion) -- [ ] 4.1 Run the cleanup pipeline: `gx branch finish --branch agent/codex/install-suite-split-and-cli-surface-clea-2026-04-22-10-52 --base main --via-pr --wait-for-merge --cleanup`. This handles commit -> push -> PR create -> merge wait -> worktree prune in one invocation. -- [ ] 4.2 Record the PR URL and final merge state (`MERGED`) in the completion handoff. -- [ ] 4.3 Confirm the sandbox worktree is gone (`git worktree list` no longer shows the agent path; `git branch -a` shows no surviving local/remote refs for the branch). +- [x] 4.1 Run the cleanup pipeline: `gx branch finish --branch agent/codex/install-suite-split-and-cli-surface-clea-2026-04-22-10-52 --base main --via-pr --wait-for-merge --cleanup`. This handles commit -> push -> PR create -> merge wait -> worktree prune in one invocation. Executed via the equivalent repo-local entrypoint `node bin/multiagent-safety.js branch finish ...` because `gx` was not on `PATH` in the recovery shell. +- [x] 4.2 Record the PR URL and final merge state (`MERGED`) in the completion handoff. Recorded PR: `https://github.com/recodeee/gitguardex/pull/288` (`MERGED`, merge commit `da9a190cbd5d6c0ab629743efac8daf01babbcfa`). +- [x] 4.3 Confirm the sandbox worktree is gone (`git worktree list` no longer shows the agent path; `git branch -a` shows no surviving local/remote refs for the branch). Verified the original worktree path was pruned and cleared the stale `origin/agent/codex/install-suite-split-and-cli-surface-clea-2026-04-22-10-52` tracking ref with `git fetch --prune origin`.