Skip to content

Commit 32352f7

Browse files
committed
lint
1 parent 9bbcd34 commit 32352f7

File tree

2 files changed

+30
-35
lines changed

2 files changed

+30
-35
lines changed

reddit_decider/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@
55
from dataclasses import dataclass
66
from datetime import timedelta
77
from enum import Enum
8+
from rust_decider import Decider as RustDecider
9+
from rust_decider import DeciderException
10+
from rust_decider import Decision
11+
from rust_decider import FeatureNotFoundException
12+
from rust_decider import ValueTypeMismatchException
813
from typing import Any
914
from typing import Callable
1015
from typing import cast
@@ -25,11 +30,6 @@
2530
from baseplate.lib.file_watcher import FileWatcher
2631
from baseplate.lib.file_watcher import WatchedFileNotAvailableError
2732
from reddit_edgecontext import ValidatedAuthenticationToken
28-
from rust_decider import Decider as RustDecider
29-
from rust_decider import DeciderException
30-
from rust_decider import Decision
31-
from rust_decider import FeatureNotFoundException
32-
from rust_decider import ValueTypeMismatchException
3333
from typing_extensions import Literal
3434

3535
from .prometheus_metrics import experiments_client_counter

tests/decider_tests.py

Lines changed: 25 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,19 +1521,14 @@ def test_range_variant_emit_event_override(self):
15211521
"type": "feature_rollout",
15221522
"emit_event": False,
15231523
"experiment": {
1524-
"variants": [
1525-
{
1526-
"name": "enabled",
1527-
"size": 1.0,
1528-
"range_end": 1.0,
1529-
"range_start": 0.0
1530-
}
1531-
],
1532-
"experiment_version": 1,
1533-
"shuffle_version": 0,
1534-
"bucket_val": "user_id",
1535-
"log_bucketing": False
1536-
}
1524+
"variants": [
1525+
{"name": "enabled", "size": 1.0, "range_end": 1.0, "range_start": 0.0}
1526+
],
1527+
"experiment_version": 1,
1528+
"shuffle_version": 0,
1529+
"bucket_val": "user_id",
1530+
"log_bucketing": False,
1531+
},
15371532
},
15381533
"measured_rollout_100": {
15391534
"id": 9119,
@@ -1547,21 +1542,21 @@ def test_range_variant_emit_event_override(self):
15471542
"emit_event": False,
15481543
"measured": True,
15491544
"experiment": {
1550-
"variants": [
1551-
{
1552-
"name": "enabled",
1553-
"size": 1.0,
1554-
"range_end": 1.0,
1555-
"range_start": 0.0,
1556-
"emit_event_override": True
1557-
}
1558-
],
1559-
"experiment_version": 1,
1560-
"shuffle_version": 0,
1561-
"bucket_val": "user_id",
1562-
"log_bucketing": False
1563-
}
1564-
}
1545+
"variants": [
1546+
{
1547+
"name": "enabled",
1548+
"size": 1.0,
1549+
"range_end": 1.0,
1550+
"range_start": 0.0,
1551+
"emit_event_override": True,
1552+
}
1553+
],
1554+
"experiment_version": 1,
1555+
"shuffle_version": 0,
1556+
"bucket_val": "user_id",
1557+
"log_bucketing": False,
1558+
},
1559+
},
15651560
}
15661561

15671562
with create_temp_config_file(cfg) as f:
@@ -1573,7 +1568,7 @@ def test_range_variant_emit_event_override(self):
15731568

15741569
# FR does NOT emit exposure
15751570
self.assertEqual(self.event_logger.log.call_count, 0)
1576-
1571+
15771572
# FR is NOT "measured"
15781573
fr_cfg = decider.get_experiment(experiment_name="feature_rollout_100")
15791574
self.assertEqual(fr_cfg.measured, False)
@@ -1583,7 +1578,7 @@ def test_range_variant_emit_event_override(self):
15831578

15841579
# Measured Rollout DOES emit exposure (due to RV "emit_event_override" field)
15851580
self.assertEqual(self.event_logger.log.call_count, 1)
1586-
1581+
15871582
# MR IS "measured"
15881583
mr_cfg = decider.get_experiment(experiment_name="measured_rollout_100")
15891584
self.assertEqual(mr_cfg.measured, True)

0 commit comments

Comments
 (0)