Merge pull request #108 from reddit/remove_feature_not_found_log

Remove `"Feature 'X' not found"` log

Author: mrlevitas

reddit_decider/__init__.py

@@ -394,8 +394,7 @@ def expose(
 
         try:
             feature = self._internal.get_feature(experiment_name)
-        except FeatureNotFoundException as exc:
-            logger.debug(str(exc))
+        except FeatureNotFoundException:
             return
         except DeciderException as exc:
             logger.info(str(exc))
@@ -805,8 +804,7 @@ def _get_decision(
 
         try:
             return self._internal.choose(experiment_name, ctx)
-        except FeatureNotFoundException as exc:
-            logger.debug(str(exc))
+        except FeatureNotFoundException:
             return None
         except DeciderException as exc:
             logger.info(str(exc))
@@ -840,8 +838,7 @@ def _get_dynamic_config_value(
 
         try:
             value = get_fn(feature_name=feature_name, context=ctx)
-        except FeatureNotFoundException as exc:
-            logger.debug(str(exc))
+        except FeatureNotFoundException:
             return default
         except ValueTypeMismatchException as exc:
             logger.info(str(exc))
@@ -877,8 +874,7 @@ def get_experiment(self, experiment_name: str) -> Optional[ExperimentConfig]:
 
         try:
             feature = self._internal.get_feature(experiment_name)
-        except FeatureNotFoundException as exc:
-            logger.debug(str(exc))
+        except FeatureNotFoundException:
             return None
         except DeciderException as exc:
             logger.info(str(exc))

tests/decider_tests.py

@@ -556,24 +556,6 @@ def test_get_variant_calls_with_partial_data(self):
             variant = decider.get_variant("exp_1")
             self.assertEqual(variant, "variant_4")
 
-    def test_none_returned_on_get_variant_call_with_experiment_not_found(self):
-        with create_temp_config_file({}) as f:
-            decider = setup_decider(
-                f, self.minimal_decider_context, self.mock_span, self.event_logger
-            )
-
-            self.assertEqual(self.event_logger.log.call_count, 0)
-            with self.assertLogs(logger, logging.DEBUG) as captured:
-                variant = decider.get_variant("anything")
-
-                assert any(
-                    'Feature "anything" not found.' in x.getMessage() for x in captured.records
-                )
-            self.assertEqual(variant, None)
-
-            # no exposures should be triggered
-            self.assertEqual(self.event_logger.log.call_count, 0)
-
     def test_get_variant_without_expose(self):
         with create_temp_config_file(self.exp_base_config) as f:
             decider = setup_decider(f, self.dc, self.mock_span, self.event_logger)
@@ -606,24 +588,6 @@ def test_get_variant_without_expose_for_holdout_exposure(self):
                 experiment_name="hg", variant="holdout", event_fields=event_fields
             )
 
-    def test_none_returned_on_get_variant_without_expose_call_with_experiment_not_found(self):
-        with create_temp_config_file({}) as f:
-            decider = setup_decider(
-                f, self.minimal_decider_context, self.mock_span, self.event_logger
-            )
-
-            self.assertEqual(self.event_logger.log.call_count, 0)
-            with self.assertLogs(logger, logging.DEBUG) as captured:
-                variant = decider.get_variant_without_expose("anything")
-
-                assert any(
-                    'Feature "anything" not found.' in x.getMessage() for x in captured.records
-                )
-            self.assertEqual(variant, None)
-
-            # no exposures should be triggered
-            self.assertEqual(self.event_logger.log.call_count, 0)
-
     def test_get_variant_for_identifier_user_id(self):
         identifier = USER_ID
         bucket_val = "user_id"