Merge pull request #87 from reddit/str_exceptions

mrlevitas · web-flow · commit 5d16aa89e4a0 · 2022-12-13T13:38:55.000-08:00
Fix exception logging
diff --git a/reddit_decider/__init__.py b/reddit_decider/__init__.py
@@ -676,7 +676,7 @@ def get_all_variants_for_identifier_without_expose(
                 context=ctx, bucketing_field_filter=identifier_type
             )
         except DeciderException as exc:
-            logger.info(exc)
+            logger.info(str(exc))
             return []
 
         parsed_choices = []
@@ -1126,8 +1126,7 @@ def make_object_for_context(self, name: str, span: Span) -> Decider:
             )
         except Exception as exc:
             logger.warning(
-                "Could not create full DeciderContext() (defaulting to empty DeciderContext()): %s",
-                str(exc),
+                f"Could not create full DeciderContext() (defaulting to empty DeciderContext()): {exc}"
             )
             decider_context = DeciderContext()
 

Original file line number	Diff line number	Diff line change
`@@ -676,7 +676,7 @@ def get_all_variants_for_identifier_without_expose(`
`676`	`676`	`context=ctx, bucketing_field_filter=identifier_type`
`677`	`677`	`)`
`678`	`678`	`except DeciderException as exc:`
`679`		`- logger.info(exc)`
	`679`	`+ logger.info(str(exc))`
`680`	`680`	`return []`
`681`	`681`
`682`	`682`	`parsed_choices = []`
`@@ -1126,8 +1126,7 @@ def make_object_for_context(self, name: str, span: Span) -> Decider:`
`1126`	`1126`	`)`
`1127`	`1127`	`except Exception as exc:`
`1128`	`1128`	`logger.warning(`
`1129`		`- "Could not create full DeciderContext() (defaulting to empty DeciderContext()): %s",`
`1130`		`- str(exc),`
	`1129`	`+ f"Could not create full DeciderContext() (defaulting to empty DeciderContext()): {exc}"`
`1131`	`1130`	`)`
`1132`	`1131`	`decider_context = DeciderContext()`
`1133`	`1132`