choose_all() no longer raises exception

Author: mrlevitas

reddit_decider/__init__.py

@@ -24,6 +24,7 @@
 from reddit_edgecontext import ValidatedAuthenticationToken
 from rust_decider import Decider as RustDecider
 from rust_decider import DeciderException
+from rust_decider import Decision
 from rust_decider import FeatureNotFoundException
 from rust_decider import make_ctx
 from typing_extensions import Literal
@@ -610,16 +611,16 @@ def get_all_variants_without_expose(self) -> List[Dict[str, Union[str, int]]]:
 
         :return: list of experiment dicts with non-:code:`None` variants.
         """
-        if self._rs_decider is None:
+        if self._internal is None:
             logger.error("rs_decider is None--did not initialize.")
             return []
 
         ctx = self._decider_context.to_dict()
 
         try:
-            all_decisions = self._rs_decider.choose_all(ctx)
+            all_decisions = self._internal.choose_all(ctx)
         except DeciderException as exc:
-            logger.info(exc)
+            logger.info(str(exc))
             return []
 
         parsed_choices = []
@@ -685,15 +686,15 @@ def get_all_variants_for_identifier_without_expose(
             )
             return []
 
-        if self._rs_decider is None:
+        if self._internal is None:
             logger.error("rs_decider is None--did not initialize.")
             return []
 
         ctx = self._decider_context.to_dict()
         ctx[identifier_type] = identifier
 
         try:
-            all_decisions = self._rs_decider.choose_all(context=ctx, bucketing_field_filter=identifier_type)
+            all_decisions = self._internal.choose_all(context=ctx, bucketing_field_filter=identifier_type)
         except DeciderException as exc:
             logger.info(exc)
             return []

tests/decider_tests.py

@@ -972,6 +972,37 @@ def test_get_all_variants_without_expose_with_hg(self):
                 experiment_name="hg", variant="holdout", event_fields=event_fields
             )
 
+    def test_get_all_variants_without_expose_ctx_missing_bucketing_key_exception(self):
+        # no device_id in ctx
+        dc = DeciderContext(user_id=USER_ID)
+
+        self.exp_base_config["exp_1"]["experiment"].update({"bucket_val": "device_id"})
+        self.exp_base_config.update(self.additional_two_exp)
+
+        with create_temp_config_file(self.exp_base_config) as f:
+            decider = setup_decider(
+                f, dc, self.mock_span, self.event_logger
+            )
+
+            self.assertEqual(self.event_logger.log.call_count, 0)
+
+            decision_arr = decider.get_all_variants_without_expose()
+
+            self.assertEqual(len(decision_arr), 2)
+
+            self.assertEqual(
+                first_occurrence_of_key_in(decision_arr, "experimentName", "e1"),
+                {"id": 6, "name": "e1treat", "version": "4", "experimentName": "e1"},
+            )
+            self.assertEqual(
+                first_occurrence_of_key_in(decision_arr, "experimentName", "e2"),
+                {"id": 7, "name": "e2treat", "version": "5", "experimentName": "e2"},
+            )
+
+            # no exposures should be triggered
+            self.assertEqual(self.event_logger.log.call_count, 0)
+
+
     def test_get_all_variants_for_identifier_without_expose_user_id(self):
         identifier = USER_ID
         bucket_val = "user_id"