Skip to content

Commit 705fc90

Browse files
committed
bump reddit-decider & add test
1 parent f89e6c8 commit 705fc90

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

docs/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ docutils==0.16
44
Jinja2==2.11.2
55
MarkupSafe==1.1.1
66
pydocstyle==5.1.1
7-
reddit-decider==1.4.0
7+
reddit-decider==1.4.1
88
reddit-edgecontext==1.0.0a3
99
Sphinx==3.4.0
1010
sphinx-autodoc-typehints==1.11.1

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
-r requirements-transitive.txt
22
baseplate>=2.0.0a1,<3.0
33
black==21.4b2
4-
reddit-decider==1.4.0
4+
reddit-decider==1.4.1
55
flake8==3.9.1
66
mypy==0.790
77
pyramid==2.0 # required for `from baseplate.frameworks.pyramid import BaseplateRequest` which calls `import pyramid.events`

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
install_requires=[
2020
"baseplate>=2.0.0a1,<3.0",
2121
"reddit-edgecontext>=1.0.0a3,<2.0",
22-
"reddit-decider~=1.4.0",
22+
"reddit-decider~=1.4.1",
2323
"typing_extensions>=3.10.0.0,<5.0",
2424
],
2525
package_data={"reddit_experiments": ["py.typed"], "reddit_decider": ["py.typed"]},

tests/decider_tests.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,6 +1630,19 @@ def test_get_map(self):
16301630
res = decider.get_string("dc_1")
16311631
self.assertEqual(res, "")
16321632

1633+
def test_get_map_disabled(self):
1634+
self.dc_base_config["dc_1"].update(
1635+
{"value_type": "Map", "value": {"key": "value", "another_key": "another_value"}}
1636+
)
1637+
self.dc_base_config["dc_1"].update({"enabled": False})
1638+
1639+
with create_temp_config_file(self.dc_base_config) as f:
1640+
decider = setup_decider(f, self.dc, self.mock_span, self.event_logger)
1641+
1642+
res = decider.get_map("dc_1")
1643+
self.assertEqual(res, None)
1644+
1645+
16331646
def test_get_all_values(self):
16341647
base_cfg = self.dc_base_config["dc_1"].copy()
16351648

0 commit comments

Comments
 (0)